Skip to content

feature: support consumer bind plugins.#544

Merged
membphis merged 22 commits intoapache:masterfrom
membphis:consumer-bind-plugin
Sep 21, 2019
Merged

feature: support consumer bind plugins.#544
membphis merged 22 commits intoapache:masterfrom
membphis:consumer-bind-plugin

Conversation

@membphis
Copy link
Copy Markdown
Member

@membphis membphis commented Sep 18, 2019 •
edited
Loading

  • test

  • doc

@membphis membphis marked this pull request as ready for review September 21, 2019 00:42
@membphis membphis added this to the ver 0.8 milestone Sep 21, 2019
juzhiyuan
juzhiyuan reviewed Sep 21, 2019
View reviewed changes
doc/architecture-design-cn.md Outdated

|字段|可选|说明|
|---|----|----|
|username|必选|Consumer 名称。|
Copy link
Copy Markdown
Member

@juzhiyuan juzhiyuan Sep 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议修改为 必选：是/否

Copy link
Copy Markdown
Member Author

@membphis membphis Sep 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, fix later

juzhiyuan
juzhiyuan reviewed Sep 21, 2019
View reviewed changes
doc/architecture-design-cn.md Outdated
如何对某个 Consumer 开启指定插件，可以看下面例子：

```shell
# 创建 Consumer ，指定认证插件 key-auth ,并开启特定插件 limit-count
Copy link
Copy Markdown
Member

@juzhiyuan juzhiyuan Sep 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应使用中文逗号

lua/apisix/plugin.lua Outdated


function _M.merge_consumer_route(route_conf, consumer_conf)
core.log.info("route conf : ", core.json.delay_encode(route_conf))
Copy link
Copy Markdown
Member

@juzhiyuan juzhiyuan Sep 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议统一 log 内容中的空格

Copy link
Copy Markdown
Member

@moonming moonming Sep 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juzhiyuan good catch, and please use English, thx

@membphis membphis merged commit de3c95d into apache:master Sep 21, 2019
@membphis membphis deleted the consumer-bind-plugin branch September 22, 2019 21:56
shreemaan-abhishek pushed a commit to shreemaan-abhishek/apisix that referenced this pull request Jan 2, 2026
@ronething @nic-6443
fix: support config attach-consumer-label plugin in global rule (apac…
b7fad14 
…he#544)

Signed-off-by: ashing <axingfly@gmail.com>
Co-authored-by: Nic <qianyong@api7.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juzhiyuan juzhiyuan juzhiyuan left review comments

@moonming moonming moonming left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ver 0.8

Development

Successfully merging this pull request may close these issues.

3 participants

@membphis @juzhiyuan @moonming
⚡