Skip to content

bugfix: key-auth plugin cannot run accurately in the case of multiple consumers(branch: master)#826

Merged
membphis merged 2 commits intoapache:masterfrom
Beckjiang:fix-consumer
Nov 10, 2019
Merged

bugfix: key-auth plugin cannot run accurately in the case of multiple consumers(branch: master)#826
membphis merged 2 commits intoapache:masterfrom
Beckjiang:fix-consumer

Conversation

@Beckjiang
Copy link
Copy Markdown
Contributor

Summary

fix the logical error in apisix/consumer.lua and improve the test case.

Full changelog

  • updated apisix/consumer.lua:40-46
  • updated the test case [TEST 7: valid consumer] - t/plugin/key-auth.t

Issues resolved

The improved test case run in branch master.
image

Run in this branch.
image

--- pipelined_requests eval
["GET /add_more_consumer", "GET /hello"]
--- more_headers
apikey: auth-one
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apikey: auth-one -> apikey: auth-13, test the new code logic.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

YES,UPDATED

@membphis
Copy link
Copy Markdown
Member

@membphis membphis merged commit 7d33fb6 into apache:master Nov 10, 2019
@membphis
Copy link
Copy Markdown
Member

@Beckjiang Merged, many thanks.

moonming pushed a commit to moonming/apisix that referenced this pull request Nov 10, 2019
moonming pushed a commit that referenced this pull request Nov 10, 2019
@Beckjiang Beckjiang deleted the fix-consumer branch December 11, 2019 07:41
shreemaan-abhishek pushed a commit to shreemaan-abhishek/apisix that referenced this pull request Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants