Update AnnotationBean.java delete duplicate code#3021
Merged
zonghaishang merged 1 commit intoapache:masterfrom Dec 30, 2018
Merged
Update AnnotationBean.java delete duplicate code#3021zonghaishang merged 1 commit intoapache:masterfrom
zonghaishang merged 1 commit intoapache:masterfrom
Conversation
delete useless code
Codecov Report
@@ Coverage Diff @@
## master #3021 +/- ##
==========================================
+ Coverage 64.24% 64.33% +0.08%
==========================================
Files 584 584
Lines 26056 26056
Branches 4562 4562
==========================================
+ Hits 16740 16762 +22
+ Misses 7132 7111 -21
+ Partials 2184 2183 -1
Continue to review full report at Codecov.
|
lixiaojiee
reviewed
Dec 20, 2018
Contributor
lixiaojiee
left a comment
There was a problem hiding this comment.
That's what it looks like
Contributor
Author
|
I don't quite understand. |
Contributor
|
Looks good to me. |
Member
|
AnnotationBean is deprecated, never should be used again. |
This was referenced Jan 7, 2019
khanimteyaz
pushed a commit
to khanimteyaz/incubator-dubbo
that referenced
this pull request
Jan 18, 2019
delete useless code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete useless code
What is the purpose of the change
delete useless code
Brief changelog
XXXXX

duplicate code
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.