Skip to content

3.x dev rx support#3626

Merged
chickenlj merged 6 commits intoapache:3.x-devfrom
uglycow:3.x-dev-rx-support
Mar 11, 2019
Merged

3.x dev rx support#3626
chickenlj merged 6 commits intoapache:3.x-devfrom
uglycow:3.x-dev-rx-support

Conversation

@uglycow
Copy link
Copy Markdown
Contributor

@uglycow uglycow commented Mar 11, 2019

What is the purpose of the change

remove author

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3626 into 3.x-dev will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             3.x-dev    #3626      +/-   ##
=============================================
+ Coverage      63.82%   63.86%   +0.04%     
  Complexity        75       75              
=============================================
  Files            656      656              
  Lines          28449    28449              
  Branches        4812     4812              
=============================================
+ Hits           18157    18169      +12     
+ Misses          8008     7995      -13     
- Partials        2284     2285       +1
Impacted Files Coverage Δ Complexity Δ
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 72.5% <0%> (-1.67%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.15% <0%> (ø) 0% <0%> (ø) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 66.1% <0%> (+0.84%) 0% <0%> (ø) ⬇️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 79.41% <0%> (+2.2%) 0% <0%> (ø) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.88% <0%> (+4.7%) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.94% <0%> (+10.52%) 0% <0%> (ø) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 56.81% <0%> (+11.36%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020697b...cb58c69. Read the comment docs.

@ralf0131
Copy link
Copy Markdown
Contributor

In your description, you mention remove author, but why there is so many changes?

@chickenlj chickenlj merged commit 6272691 into apache:3.x-dev Mar 11, 2019
@chickenlj
Copy link
Copy Markdown
Contributor

I confirmed the actual changes are limited to 'author removing', no code is changed as committer declares.
@uglycow Please keep your local repo synced with the official repo to avoid misleading hint from git comparator the next time.

@ralf0131
Copy link
Copy Markdown
Contributor

@chickenlj Could you please approve the pull request officially first before merge it?

@ralf0131
Copy link
Copy Markdown
Contributor

I confirmed the actual changes are limited to 'author removing', no code is changed as committer declares.
@uglycow Please keep your local repo synced with the official repo to avoid misleading hint from git comparator the next time.

Maybe there is some CRLF issues. Did you set autocrlf in your git configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants