Skip to content

improve:change serviceMetadata order#3754

Merged
chickenlj merged 3 commits intoapache:3.x-devfrom
qinliujie:improve/serviceMetadataOrder
Apr 23, 2019
Merged

improve:change serviceMetadata order#3754
chickenlj merged 3 commits intoapache:3.x-devfrom
qinliujie:improve/serviceMetadataOrder

Conversation

@qinliujie
Copy link
Copy Markdown
Contributor

What is the purpose of the change

change service metadata init order, so that we can use service metadata when ServiceConfig/ReferenceConfig init

Brief changelog

change service metadata init order

Copy link
Copy Markdown
Contributor

@Jeff-Lv Jeff-Lv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@ralf0131
Copy link
Copy Markdown
Contributor

ralf0131 commented Apr 5, 2019

@Jeff-Lv You can merge it if you feel confident. Do you still want others to review?

Copy link
Copy Markdown
Contributor

@Jeff-Lv Jeff-Lv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants