Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3786 +/- ##
===========================================
- Coverage 63.58% 63.48% -0.1%
Complexity 71 71
===========================================
Files 704 705 +1
Lines 31063 31131 +68
Branches 5037 5048 +11
===========================================
+ Hits 19751 19765 +14
- Misses 9037 9087 +50
- Partials 2275 2279 +4
Continue to review full report at Codecov.
|
ralf0131
reviewed
Apr 3, 2019
Contributor
ralf0131
left a comment
There was a problem hiding this comment.
What is the LICENSE of your dependencies? Could you please list them?
Contributor
Author
|
The JSON-RPC moudle dependends on the <groupId>com.github.briandilley.jsonrpc4j</groupId>
<artifactId>jsonrpc4j</artifactId>
<version>1.2.0</version>and its license is <licenses>
<license>
<name>The MIT License (MIT)</name>
<url>http://opensource.org/licenses/MIT</url>
<distribution>repo</distribution>
</license>
</licenses> |
ralf0131
requested changes
Apr 8, 2019
ralf0131
approved these changes
Apr 9, 2019
Contributor
ralf0131
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
add a new protocol JSON-RPC. The changes were moved from the origin repository: https://github.com/apache/incubator-dubbo-rpc-jsonrpc