Skip to content

polish code#3820

Merged
kezhenxu94 merged 3 commits intoapache:masterfrom
chenlushun:master
Apr 7, 2019
Merged

polish code#3820
kezhenxu94 merged 3 commits intoapache:masterfrom
chenlushun:master

Conversation

@chenlushun
Copy link
Copy Markdown
Contributor

What is the purpose of the change

polish code

Brief changelog

incubator-dubbo/dubbo-registry/dubbo-registry-zookeeper/pom.xml
org.apache.dubbo.registry.zookeeper.ZookeeperRegistry

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3820 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3820      +/-   ##
===========================================
+ Coverage     63.54%   63.6%   +0.05%     
  Complexity       71      71              
===========================================
  Files           704     704              
  Lines         31065   31065              
  Branches       5037    5037              
===========================================
+ Hits          19741   19759      +18     
+ Misses         9050    9034      -16     
+ Partials       2274    2272       -2
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 67.37% <100%> (ø) 0 <0> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-0.95%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 73.46% <0%> (ø) 0% <0%> (ø) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 69.68% <0%> (+1.8%) 0% <0%> (ø) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 62.2% <0%> (+2.36%) 0% <0%> (ø) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 70.49% <0%> (+3.27%) 0% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 62.35% <0%> (+4.7%) 0% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6feaf57...a29d909. Read the comment docs.

Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants