There's no need to null test in conjunction with an instanceof test. …#3940
Merged
kun-song merged 1 commit intoapache:masterfrom Apr 29, 2019
liugddx:master
Merged
There's no need to null test in conjunction with an instanceof test. …#3940kun-song merged 1 commit intoapache:masterfrom liugddx:master
kun-song merged 1 commit intoapache:masterfrom
liugddx:master
Conversation
…null is not an instanceof anything, so a null check is redundant.
ralf0131
approved these changes
Apr 28, 2019
Contributor
ralf0131
left a comment
There was a problem hiding this comment.
LGTM, thanks for the pull request!
Contributor
|
Please merge it if All CI pass. |
Contributor
|
Hi @ralf0131 , the CI seems not happy: The command "~/bin/install-jdk.sh --target "/home/travis/openjdk11" --workspace "/home/travis/.cache/install-jdk" --feature "11" --license "GPL" --cacerts" failed and exited with 51 during .Maybe a same problem to this Travis CI couldn't install openjdk11 |
Contributor
|
We already have a PR to fix it #3948 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…null is not an instanceof anything, so a null check is redundant.
What is the purpose of the change
There's no need to null test in conjunction with an instanceof test. null is not an instanceof anything, so a null check is redundant.
Brief changelog
There's no need to null test in conjunction with an instanceof test. null is not an instanceof anything, so a null check is redundant.
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.