fixed provider set delay NullPointerException#3957
Merged
beiwei30 merged 3 commits intoapache:masterfrom Apr 30, 2019
Leishunyu:fix-delay
Merged
fixed provider set delay NullPointerException#3957beiwei30 merged 3 commits intoapache:masterfrom Leishunyu:fix-delay
beiwei30 merged 3 commits intoapache:masterfrom
Leishunyu:fix-delay
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3957 +/- ##
===========================================
- Coverage 63.97% 63.9% -0.07%
Complexity 98 98
===========================================
Files 713 713
Lines 31481 31482 +1
Branches 5076 5076
===========================================
- Hits 20139 20118 -21
- Misses 9038 9055 +17
- Partials 2304 2309 +5
Continue to review full report at Codecov.
|
ralf0131
previously requested changes
Apr 30, 2019
Member
|
LGTM. I will follow up to make it better, since I also need to take care shouldExport too. Thanks. |
beiwei30
approved these changes
Apr 30, 2019
Contributor
This change does not look good to me. Why it is getting merged? |
6 tasks
Member
|
@ralf0131 @Leishunyu pls. review #3959 |
Contributor
|
The pull request looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#3952
fixed this bug
Brief changelog
provider's delay has not set in serviceconfig
Verifying this change
set provider's delay in serviceconfig
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.