fix telnet not work in some scene (#4007)#4026
fix telnet not work in some scene (#4007)#4026ralf0131 merged 1 commit intoapache:masterfrom fibbery:fixbugs
Conversation
ralf0131
left a comment
There was a problem hiding this comment.
Hi, thanks for the pull request, could write a unit test to cover this change?
|
Hey, it looks like the UT is failing, could you please take a look? |
Codecov Report
@@ Coverage Diff @@
## master #4026 +/- ##
============================================
- Coverage 63.11% 62.44% -0.68%
Complexity 564 564
============================================
Files 753 774 +21
Lines 32411 34260 +1849
Branches 5143 5386 +243
============================================
+ Hits 20455 21392 +937
- Misses 9604 10404 +800
- Partials 2352 2464 +112
Continue to review full report at Codecov.
|
|
It failed because the license check. I think it is due to that you added a new java file but no have ASF license header. |
|
@ralf0131 |
[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.672 s <<< FAILURE! - in org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest
[ERROR] testStoreProvider Time elapsed: 2.895 s <<< ERROR!
java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest.testStoreProvider(EtcdMetadataReportTest.java:85)why occur only in openjdk11 @ralf0131 |
ralf0131
left a comment
There was a problem hiding this comment.
LGTM, will merge if CI pass. I triggered it manually.
What is the purpose of the change
fix #4007
Brief changelog
XXXXX
Verifying this change
org.apache.dubbo.common.utils.PojoUtilsTest#test_has_no_nullary_constructor_pojo()
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.