Skip to content

comment diabled nacos test#4088

Merged
ralf0131 merged 1 commit intoapache:masterfrom
Moriadry-zz:feature/comment
May 18, 2019
Merged

comment diabled nacos test#4088
ralf0131 merged 1 commit intoapache:masterfrom
Moriadry-zz:feature/comment

Conversation

@Moriadry-zz
Copy link
Copy Markdown

What is the purpose of the change

add some comments, fix this later when nacos support is ready

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Copy Markdown
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ralf0131 ralf0131 merged commit 13f3238 into apache:master May 18, 2019
@Moriadry-zz Moriadry-zz deleted the feature/comment branch May 18, 2019 08:45
@cvictory cvictory added this to the 2.7.2 milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants