Skip to content

Polish apache/incubator-dubbo/#4096 : To add new module for Dubbo Event#4099

Merged
chickenlj merged 11 commits intoapache:cloud-nativefrom
mercyblitz:cloud-native-2.7.2
May 23, 2019
Merged

Polish apache/incubator-dubbo/#4096 : To add new module for Dubbo Event#4099
chickenlj merged 11 commits intoapache:cloud-nativefrom
mercyblitz:cloud-native-2.7.2

Conversation

@mercyblitz
Copy link
Copy Markdown
Contributor

@mercyblitz mercyblitz added this to the 2.7.2 milestone May 20, 2019
@mercyblitz mercyblitz requested a review from cvictory May 20, 2019 07:48
@mercyblitz mercyblitz changed the base branch from master to cloud-native May 20, 2019 07:49
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #4099 into cloud-native will increase coverage by 0.1%.
The diff coverage is 80.76%.

Impacted file tree graph

@@                Coverage Diff                @@
##             cloud-native    #4099     +/-   ##
=================================================
+ Coverage           62.71%   62.81%   +0.1%     
- Complexity            545      584     +39     
=================================================
  Files                 762      770      +8     
  Lines               32752    32882    +130     
  Branches             5162     5172     +10     
=================================================
+ Hits                20539    20656    +117     
- Misses               9856     9861      +5     
- Partials             2357     2365      +8
Impacted Files Coverage Δ Complexity Δ
...main/java/org/apache/dubbo/event/GenericEvent.java 100% <100%> (ø) 2 <2> (?)
...nt/src/main/java/org/apache/dubbo/event/Event.java 100% <100%> (ø) 2 <2> (?)
...rg/apache/dubbo/event/ParallelEventDispatcher.java 100% <100%> (ø) 1 <1> (?)
.../org/apache/dubbo/event/DirectEventDispatcher.java 100% <100%> (ø) 1 <1> (?)
...va/org/apache/dubbo/common/utils/ReflectUtils.java 68.05% <33.33%> (-1.44%) 0 <0> (ø)
...n/java/org/apache/dubbo/event/EventDispatcher.java 66.66% <66.66%> (ø) 2 <2> (?)
...c/main/java/org/apache/dubbo/event/Listenable.java 77.77% <77.77%> (ø) 5 <5> (?)
...ain/java/org/apache/dubbo/event/EventListener.java 86.95% <86.95%> (ø) 9 <9> (?)
...rg/apache/dubbo/event/AbstractEventDispatcher.java 94.44% <94.44%> (ø) 17 <17> (?)
...apache/dubbo/common/config/ConfigurationUtils.java 64% <0%> (-8%) 0% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d1a65...9a42780. Read the comment docs.

Comment thread dubbo-event/src/main/java/org/apache/dubbo/event/Listenable.java Outdated
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 097e762 into apache:cloud-native May 23, 2019
@mercyblitz mercyblitz deleted the cloud-native-2.7.2 branch May 31, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants