Skip to content

rm incubating word#4110

Merged
lovepoem merged 2 commits intoapache:masterfrom
Leishunyu:rm-incubating
May 22, 2019
Merged

rm incubating word#4110
lovepoem merged 2 commits intoapache:masterfrom
Leishunyu:rm-incubating

Conversation

@Leishunyu
Copy link
Copy Markdown
Contributor

What is the purpose of the change

#4108

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Comment thread README.md Outdated
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 22, 2019

Codecov Report

Merging #4110 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4110      +/-   ##
============================================
+ Coverage     62.57%   62.67%   +0.09%     
- Complexity      543      544       +1     
============================================
  Files           762      762              
  Lines         32752    32752              
  Branches       5162     5162              
============================================
+ Hits          20496    20528      +32     
+ Misses         9896     9863      -33     
- Partials       2360     2361       +1
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.7% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 62.2% <0%> (+2.36%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 81.6% <0%> (+3.06%) 0% <0%> (ø) ⬇️
.../org/apache/dubbo/remoting/ExecutionException.java 21.05% <0%> (+5.26%) 0% <0%> (ø) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 57.14% <0%> (+5.71%) 0% <0%> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 71.42% <0%> (+9.52%) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.94% <0%> (+10.52%) 17% <0%> (+1%) ⬆️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 56.81% <0%> (+11.36%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc6909...473d604. Read the comment docs.

Copy link
Copy Markdown
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lovepoem
Copy link
Copy Markdown
Member

LGTM

@lovepoem lovepoem merged commit 52cbfc9 into apache:master May 22, 2019
@Leishunyu Leishunyu deleted the rm-incubating branch June 25, 2019 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants