fix for #4111 do not ignore empty value when we construct servicename#4112
Merged
ralf0131 merged 4 commits intoapache:masterfrom May 23, 2019
uglycow:master
Merged
fix for #4111 do not ignore empty value when we construct servicename#4112ralf0131 merged 4 commits intoapache:masterfrom uglycow:master
ralf0131 merged 4 commits intoapache:masterfrom
uglycow:master
Conversation
added 2 commits
May 20, 2019 16:21
Codecov Report
@@ Coverage Diff @@
## master #4112 +/- ##
============================================
+ Coverage 62.63% 62.64% +<.01%
- Complexity 543 545 +2
============================================
Files 762 762
Lines 32752 32753 +1
Branches 5162 5162
============================================
+ Hits 20515 20517 +2
+ Misses 9876 9875 -1
Partials 2361 2361
Continue to review full report at Codecov.
|
Moriadry-zz
suggested changes
May 22, 2019
Moriadry-zz
left a comment
There was a problem hiding this comment.
I believe if no ignore empty value, two provider with same service but different config still get different service name, Is that true?
added 2 commits
May 22, 2019 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
XXXXX
Brief changelog
fix for #4111
do not ignore empty value when we construct servicename
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.