Skip to content

Commit ece9a38

Browse files
Improve dependencies filtering in AbstractAnalyzeMojo
For empty exclusion we cen return the same collection of artifacts
1 parent 4e021c0 commit ece9a38

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import java.io.File;
2222
import java.io.StringWriter;
23-
import java.util.ArrayList;
2423
import java.util.Arrays;
2524
import java.util.Iterator;
2625
import java.util.LinkedHashMap;
@@ -558,9 +557,12 @@ private void writeScriptableOutput(Set<Artifact> artifacts) {
558557
}
559558
}
560559

561-
private List<Artifact> filterDependencies(Set<Artifact> artifacts, String[] excludes) {
560+
private Set<Artifact> filterDependencies(Set<Artifact> artifacts, String[] excludes) {
561+
if (excludes == null || excludes.length == 0) {
562+
return artifacts;
563+
}
562564
ArtifactFilter filter = new StrictPatternExcludesArtifactFilter(Arrays.asList(excludes));
563-
List<Artifact> result = new ArrayList<>();
565+
Set<Artifact> result = new LinkedHashSet<>();
564566

565567
for (Iterator<Artifact> it = artifacts.iterator(); it.hasNext(); ) {
566568
Artifact artifact = it.next();

0 commit comments

Comments
 (0)