Remove unused local variables (#245)

* Remove unused local variables

* Convert method to not return anything

---------

Co-authored-by: Piotrek Żygieło <pzygielo@users.noreply.github.com>

Author: pzygielo

maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java

@@ -294,7 +294,7 @@ private void transformDocument(
 
         Properties properties = modelTarget.getProperties();
 
-        String parentVersion = rewriteParent(project, modelTarget, result, releaseDescriptor, simulate);
+        rewriteParent(project, modelTarget, result, releaseDescriptor, simulate);
 
         String projectId = ArtifactUtils.versionlessKey(project.getGroupId(), project.getArtifactId());
 
@@ -485,18 +485,17 @@ public static boolean isCiFriendlyVersion(String version) {
         return CI_FRIENDLY_PROPERTIES.contains(extractPropertyFromExpression(version));
     }
 
-    private String rewriteParent(
+    private void rewriteParent(
             MavenProject project,
             Model targetModel,
             ReleaseResult result,
             ReleaseDescriptor releaseDescriptor,
             boolean simulate)
             throws ReleaseFailureException {
-        String parentVersion = null;
         if (project.hasParent()) {
             MavenProject parent = project.getParent();
             String key = ArtifactUtils.versionlessKey(parent.getGroupId(), parent.getArtifactId());
-            parentVersion = getNextVersion(releaseDescriptor, key);
+            String parentVersion = getNextVersion(releaseDescriptor, key);
             if (parentVersion == null) {
                 // MRELEASE-317
                 parentVersion = getResolvedSnapshotVersion(key, releaseDescriptor);
@@ -516,7 +515,6 @@ private String rewriteParent(
                 }
             }
         }
-        return parentVersion;
     }
 
     private void rewriteArtifactVersions(

maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/GenerateReleasePomsPhase.java

@@ -230,7 +230,6 @@ private Model createReleaseModel(
         releaseProject.getBuild().setPluginManagement(null);
 
         // update project version
-        String projectVersion = releaseModel.getVersion();
         String releaseVersion = getNextVersion(releaseDescriptor, project.getGroupId(), project.getArtifactId());
         releaseModel.setVersion(releaseVersion);