[feat] improved s7 opcua support (#2463)

* chore: Added a test for my S7-1500 opcua setup and did some minor tweaks to support reading and writing most types on this PLC.

* chore: Fixed the build

* chore: Ported the initial fix for the reading of arrays.

Author: chrisdutz

plc4go/assets/testing/protocols/opcua/DriverTestsuite.xml

@@ -1338,7 +1338,7 @@
           <tags isList="true">
             <tag className="org.apache.plc4x.test.driver.internal.api.TestTag">
               <name>time</name>
-              <address>ns=0;i=2258</address>
+              <address>ns=0;i=2258;DATE_AND_TIME</address>
             </tag>
           </tags>
         </TestReadRequest>
@@ -1681,7 +1681,7 @@
                         <OpcuaTag>
                           <nodeId dataType="string" bitLength="88" encoding="UTF-8">ns=0;i=2258</nodeId>
                           <attributeId dataType="string" bitLength="40" encoding="UTF-8">Value</attributeId>
-                          <dataType dataType="string" bitLength="32" encoding="UTF-8">NULL</dataType>
+                          <dataType dataType="string" bitLength="104" encoding="UTF-8">DATE_AND_TIME</dataType>
                         </OpcuaTag>
                       </tag>
                     </PlcTagItem>

plc4j/drivers/opcua/pom.xml

@@ -110,6 +110,7 @@
         <groupId>org.jacoco</groupId>
         <artifactId>jacoco-maven-plugin</artifactId>
         <configuration>
+          <haltOnFailure>false</haltOnFailure>
           <excludes>
             <exclude>org/eclipse/**/*</exclude>
           </excludes>

plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/Variant.java

@@ -44,13 +44,13 @@ public abstract class Variant implements Message {
   protected final boolean arrayLengthSpecified;
   protected final boolean arrayDimensionsSpecified;
   protected final Integer noOfArrayDimensions;
-  protected final List<Boolean> arrayDimensions;
+  protected final List<Integer> arrayDimensions;
 
   public Variant(
       boolean arrayLengthSpecified,
       boolean arrayDimensionsSpecified,
       Integer noOfArrayDimensions,
-      List<Boolean> arrayDimensions) {
+      List<Integer> arrayDimensions) {
     super();
     this.arrayLengthSpecified = arrayLengthSpecified;
     this.arrayDimensionsSpecified = arrayDimensionsSpecified;
@@ -70,7 +70,7 @@ public Integer getNoOfArrayDimensions() {
     return noOfArrayDimensions;
   }
 
-  public List<Boolean> getArrayDimensions() {
+  public List<Integer> getArrayDimensions() {
     return arrayDimensions;
   }
 
@@ -99,7 +99,7 @@ public void serialize(WriteBuffer writeBuffer) throws SerializationException {
     writeOptionalField("noOfArrayDimensions", noOfArrayDimensions, writeSignedInt(writeBuffer, 32));
 
     // Array Field (arrayDimensions)
-    writeSimpleTypeArrayField("arrayDimensions", arrayDimensions, writeBoolean(writeBuffer));
+    writeSimpleTypeArrayField("arrayDimensions", arrayDimensions, writeSignedInt(writeBuffer, 32));
 
     writeBuffer.popContext("Variant");
   }
@@ -133,7 +133,7 @@ public int getLengthInBits() {
 
     // Array field
     if (arrayDimensions != null) {
-      lengthInBits += 1 * arrayDimensions.size();
+      lengthInBits += 32 * arrayDimensions.size();
     }
 
     return lengthInBits;
@@ -222,10 +222,10 @@ public static Variant staticParse(ReadBuffer readBuffer) throws ParseException {
         readOptionalField(
             "noOfArrayDimensions", readSignedInt(readBuffer, 32), arrayDimensionsSpecified);
 
-    List<Boolean> arrayDimensions =
+    List<Integer> arrayDimensions =
         readCountArrayField(
             "arrayDimensions",
-            readBoolean(readBuffer),
+            readSignedInt(readBuffer, 32),
             (((noOfArrayDimensions) == (null)) ? 0 : noOfArrayDimensions));
 
     readBuffer.closeContext("Variant");
@@ -241,7 +241,7 @@ Variant build(
         boolean arrayLengthSpecified,
         boolean arrayDimensionsSpecified,
         Integer noOfArrayDimensions,
-        List<Boolean> arrayDimensions);
+        List<Integer> arrayDimensions);
   }
 
   @Override

plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/VariantBoolean.java

@@ -50,7 +50,7 @@ public VariantBoolean(
       boolean arrayLengthSpecified,
       boolean arrayDimensionsSpecified,
       Integer noOfArrayDimensions,
-      List<Boolean> arrayDimensions,
+      List<Integer> arrayDimensions,
       Integer arrayLength,
       byte[] value) {
     super(arrayLengthSpecified, arrayDimensionsSpecified, noOfArrayDimensions, arrayDimensions);
@@ -136,7 +136,7 @@ public VariantBoolean build(
         boolean arrayLengthSpecified,
         boolean arrayDimensionsSpecified,
         Integer noOfArrayDimensions,
-        List<Boolean> arrayDimensions) {
+        List<Integer> arrayDimensions) {
       VariantBoolean variantBoolean =
           new VariantBoolean(
               arrayLengthSpecified,

plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/VariantByte.java

@@ -50,7 +50,7 @@ public VariantByte(
       boolean arrayLengthSpecified,
       boolean arrayDimensionsSpecified,
       Integer noOfArrayDimensions,
-      List<Boolean> arrayDimensions,
+      List<Integer> arrayDimensions,
       Integer arrayLength,
       List<Short> value) {
     super(arrayLengthSpecified, arrayDimensionsSpecified, noOfArrayDimensions, arrayDimensions);
@@ -138,7 +138,7 @@ public VariantByte build(
         boolean arrayLengthSpecified,
         boolean arrayDimensionsSpecified,
         Integer noOfArrayDimensions,
-        List<Boolean> arrayDimensions) {
+        List<Integer> arrayDimensions) {
       VariantByte variantByte =
           new VariantByte(
               arrayLengthSpecified,

plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/VariantByteString.java

@@ -50,7 +50,7 @@ public VariantByteString(
       boolean arrayLengthSpecified,
       boolean arrayDimensionsSpecified,
       Integer noOfArrayDimensions,
-      List<Boolean> arrayDimensions,
+      List<Integer> arrayDimensions,
       Integer arrayLength,
       List<ByteStringArray> value) {
     super(arrayLengthSpecified, arrayDimensionsSpecified, noOfArrayDimensions, arrayDimensions);
@@ -142,7 +142,7 @@ public VariantByteString build(
         boolean arrayLengthSpecified,
         boolean arrayDimensionsSpecified,
         Integer noOfArrayDimensions,
-        List<Boolean> arrayDimensions) {
+        List<Integer> arrayDimensions) {
       VariantByteString variantByteString =
           new VariantByteString(
               arrayLengthSpecified,

plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/VariantDataValue.java

@@ -50,7 +50,7 @@ public VariantDataValue(
       boolean arrayLengthSpecified,
       boolean arrayDimensionsSpecified,
       Integer noOfArrayDimensions,
-      List<Boolean> arrayDimensions,
+      List<Integer> arrayDimensions,
       Integer arrayLength,
       List<DataValue> value) {
     super(arrayLengthSpecified, arrayDimensionsSpecified, noOfArrayDimensions, arrayDimensions);
@@ -142,7 +142,7 @@ public VariantDataValue build(
         boolean arrayLengthSpecified,
         boolean arrayDimensionsSpecified,
         Integer noOfArrayDimensions,
-        List<Boolean> arrayDimensions) {
+        List<Integer> arrayDimensions) {
       VariantDataValue variantDataValue =
           new VariantDataValue(
               arrayLengthSpecified,

plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/VariantDateTime.java

@@ -50,7 +50,7 @@ public VariantDateTime(
       boolean arrayLengthSpecified,
       boolean arrayDimensionsSpecified,
       Integer noOfArrayDimensions,
-      List<Boolean> arrayDimensions,
+      List<Integer> arrayDimensions,
       Integer arrayLength,
       List<Long> value) {
     super(arrayLengthSpecified, arrayDimensionsSpecified, noOfArrayDimensions, arrayDimensions);
@@ -136,7 +136,7 @@ public VariantDateTime build(
         boolean arrayLengthSpecified,
         boolean arrayDimensionsSpecified,
         Integer noOfArrayDimensions,
-        List<Boolean> arrayDimensions) {
+        List<Integer> arrayDimensions) {
       VariantDateTime variantDateTime =
           new VariantDateTime(
               arrayLengthSpecified,

plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/VariantDiagnosticInfo.java

@@ -50,7 +50,7 @@ public VariantDiagnosticInfo(
       boolean arrayLengthSpecified,
       boolean arrayDimensionsSpecified,
       Integer noOfArrayDimensions,
-      List<Boolean> arrayDimensions,
+      List<Integer> arrayDimensions,
       Integer arrayLength,
       List<DiagnosticInfo> value) {
     super(arrayLengthSpecified, arrayDimensionsSpecified, noOfArrayDimensions, arrayDimensions);
@@ -142,7 +142,7 @@ public VariantDiagnosticInfo build(
         boolean arrayLengthSpecified,
         boolean arrayDimensionsSpecified,
         Integer noOfArrayDimensions,
-        List<Boolean> arrayDimensions) {
+        List<Integer> arrayDimensions) {
       VariantDiagnosticInfo variantDiagnosticInfo =
           new VariantDiagnosticInfo(
               arrayLengthSpecified,

plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/VariantDouble.java

@@ -50,7 +50,7 @@ public VariantDouble(
       boolean arrayLengthSpecified,
       boolean arrayDimensionsSpecified,
       Integer noOfArrayDimensions,
-      List<Boolean> arrayDimensions,
+      List<Integer> arrayDimensions,
       Integer arrayLength,
       List<Double> value) {
     super(arrayLengthSpecified, arrayDimensionsSpecified, noOfArrayDimensions, arrayDimensions);
@@ -136,7 +136,7 @@ public VariantDouble build(
         boolean arrayLengthSpecified,
         boolean arrayDimensionsSpecified,
         Integer noOfArrayDimensions,
-        List<Boolean> arrayDimensions) {
+        List<Integer> arrayDimensions) {
       VariantDouble variantDouble =
           new VariantDouble(
               arrayLengthSpecified,