Don't cancel the subscription until after we've waited for it 🤦‍♀️ 🤦‍♀️

designatednerd · designatednerd · commit 4eb1f2a6a102 · 2020-08-04T16:27:58.000-05:00
diff --git a/Tests/ApolloWebsocketTests/StarWarsSubscriptionTests.swift b/Tests/ApolloWebsocketTests/StarWarsSubscriptionTests.swift
@@ -471,10 +471,10 @@ class StarWarsSubscriptionTests: XCTestCase {
     // Now that we've reconnected, this should go through to the same subscription.
     sendReview()
     
-    // Cancel subscription so it doesn't keep receiving from other tests.
-    sub.cancel()
-    
     self.wait(for: [subscriptionExpectation], timeout: 10)
+
+    // Cancel subscription so it doesn't keep receiving from other tests.
+    sub.cancel()    
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -471,10 +471,10 @@ class StarWarsSubscriptionTests: XCTestCase {`
`471`	`471`	`// Now that we've reconnected, this should go through to the same subscription.`
`472`	`472`	`sendReview()`
`473`	`473`
`474`		`- // Cancel subscription so it doesn't keep receiving from other tests.`
`475`		`- sub.cancel()`
`476`		`-`
`477`	`474`	`self.wait(for: [subscriptionExpectation], timeout: 10)`
	`475`	`+`
	`476`	`+ // Cancel subscription so it doesn't keep receiving from other tests.`
	`477`	`+ sub.cancel()`
`478`	`478`	`}`
`479`	`479`	`}`
`480`	`480`