Skip to content

Commit b61dee3

Browse files
authored
Add correct project references for apollo-server-cloud-functions. (#1948)
* Add correct project references for `apollo-server-cloud-functions`. The `apollo-server-cloud-functions` has been been mis-referenced (or referenced inconsistently) since its original inception in #1446 when its package directory was `apollo-server-cloud-function` (singular!) and the `package.json` referenced the plural form (`apollo-server-cloud-functions`): 724d9ff0#diff-e1d725fd66f7e9ef5251abf0437a09ca These references have been mostly fixed in the READMEs and supporting documentation, but the underlying monorepo directory structure has still not been fixed, which I'm sure contributed to this module being overlooked and unreferenced in the move to TypeScript project references in #1772. Additionally, the lack of referencing in the monorepo's TS config has resulted in it being broken in the most recent 2.2.0 release, as reported by @pyros2097 and @thetre97 in: #1896 (comment) This should fix that by properly adding the TypeScript project references. * Sorting.
1 parent d36eea0 commit b61dee3

14 files changed

Lines changed: 12 additions & 0 deletions

package-lock.json

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
"apollo-server-cache-memcached": "file:packages/apollo-server-cache-memcached",
4646
"apollo-server-cache-redis": "file:packages/apollo-server-cache-redis",
4747
"apollo-server-caching": "file:packages/apollo-server-caching",
48+
"apollo-server-cloud-functions": "file:packages/apollo-server-cloud-functions",
4849
"apollo-server-cloudflare": "file:packages/apollo-server-cloudflare",
4950
"apollo-server-core": "file:packages/apollo-server-core",
5051
"apollo-server-env": "file:packages/apollo-server-env",
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

packages/apollo-server-cloud-function/src/ApolloServer.ts renamed to packages/apollo-server-cloud-functions/src/ApolloServer.ts

File renamed without changes.

packages/apollo-server-cloud-function/src/__tests__/googleCloudApollo.test.ts renamed to packages/apollo-server-cloud-functions/src/__tests__/googleCloudApollo.test.ts

File renamed without changes.

packages/apollo-server-cloud-function/src/__tests__/tsconfig.json renamed to packages/apollo-server-cloud-functions/src/__tests__/tsconfig.json

File renamed without changes.

packages/apollo-server-cloud-function/src/googleCloudApollo.ts renamed to packages/apollo-server-cloud-functions/src/googleCloudApollo.ts

File renamed without changes.

0 commit comments

Comments
 (0)