Revert "removed warnings from UploadAndComposePartialSchema and RemoveServiceAndCompose"

This reverts commit 4e9dbeb.

Author: caydie-tran

packages/apollo-language-server/src/graphqlTypes.ts

@@ -52,11 +52,11 @@ export interface CheckPartialSchema_service {
   __typename: "ServiceMutation";
   /**
    * This mutation will not result in any changes to the implementing service
-   *
+   * 
    * Run composition with the Implementing Service's partial schema replaced with the one provided
    * in the mutation's input. Store the composed schema, return the hash of the composed schema,
    * and any warnings and errors pertaining to composition.
-   *
+   * 
    * This mutation will not run validation against operations.
    */
   validatePartialSchemaOfImplementingServiceAgainstGraph: CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph;
@@ -179,11 +179,11 @@ export interface CheckSchema_service {
   /**
    * Validate, diff, and store a schema so the diff can be viewed by users in the UI.
    * This mutation will not mark the schema as "published".
-   *
+   * 
    * One of "proposedSchema" or "proposedSchemaHash" must be provided.
    * If both are provided, the computed schema hash will be compared with the input hash,
    * an error will be returned if the hashes don't match.
-   *
+   * 
    * If the "proposedSchemaHash" is specified, the already stored schema will be loaded.
    */
   checkSchema: CheckSchema_service_checkSchema;
@@ -320,6 +320,12 @@ export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTri
   line: number;
 }
 
+export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition_warnings {
+  __typename: "SchemaCompositionWarning";
+  locations: (RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition_warnings_locations | null)[];
+  message: string;
+}
+
 export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition {
   __typename: "CompositionAndRemoveResult";
   /**
@@ -332,6 +338,14 @@ export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTri
    * published to the implementing service if there were any errors encountered
    */
   errors: (RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition_errors | null)[];
+  /**
+   * List of warnings encountered during composing implementing services into a complete schema.
+   * Though a schema was composed for the graph with the proposed partial schema,
+   * these warnings may indicate undesired behavior or lost information. We recommend that no service
+   * is pushed with warnings that are not fully understood. Pushing an implementing service with warnings
+   * in its composition result will result in updating the composition config.
+   */
+  warnings: (RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition_warnings | null)[];
   /**
    * Whether the gateway link was updated.
    */
@@ -442,6 +456,11 @@ export interface UploadAndComposePartialSchema_service_upsertImplementingService
   message: string;
 }
 
+export interface UploadAndComposePartialSchema_service_upsertImplementingServiceAndTriggerComposition_warnings {
+  __typename: "SchemaCompositionWarning";
+  message: string;
+}
+
 export interface UploadAndComposePartialSchema_service_upsertImplementingServiceAndTriggerComposition {
   __typename: "CompositionAndUpsertResult";
   /**
@@ -454,6 +473,14 @@ export interface UploadAndComposePartialSchema_service_upsertImplementingService
    * published to the implementing service if there were any errors encountered
    */
   errors: (UploadAndComposePartialSchema_service_upsertImplementingServiceAndTriggerComposition_errors | null)[];
+  /**
+   * List of warnings encountered during composing implementing services into a complete schema.
+   * Though a schema was composed for the graph with the proposed partial schema,
+   * these warnings may indicate undesired behavior or lost information. We recommend that no service
+   * is pushed with warnings that are not fully understood. Pushing an implementing service with warnings
+   * in its composition result will result in updating the composition config.
+   */
+  warnings: (UploadAndComposePartialSchema_service_upsertImplementingServiceAndTriggerComposition_warnings | null)[];
   /**
    * Whether the gateway link was updated.
    */
@@ -469,10 +496,10 @@ export interface UploadAndComposePartialSchema_service {
   /**
    * Creates or updates an implementing service of a given "name" on the graph variant, then
    * updates the graph variant's composition configs/artifacts to reflect these changes.
-   *
+   * 
    * An enriched SDL of the implementing service can be uploaded
    * via "implementingServiceConfiguration.partialSchema.partialSchemaSDL".
-   *
+   * 
    * Alternatively, previously uploaded partial schema could be re-associated with the
    * implementing service via "implementingServiceConfiguration.partialSchema.partialSchemaHash".
    */
@@ -1676,10 +1703,10 @@ export interface OperationDocumentInput {
 /**
  * Input for registering a partial schema to an implementing service.
  * One of the fields must be specified (validated server-side).
- *
+ * 
  * If a new partialSchemaSDL is passed in, this operation will store it before
  * creating the association.
- *
+ * 
  * If both the sdl and hash are specified, an error will be thrown if the provided
  * hash doesn't match our hash of the sdl contents
  */

packages/apollo/src/commands/service/delete.ts

@@ -44,6 +44,7 @@ export default class ServiceDelete extends ProjectCommand {
 
           const {
             errors,
+            warnings,
             updatedGateway
           } = await project.engine.removeServiceAndCompose({
             id: config.name,
@@ -55,6 +56,7 @@ export default class ServiceDelete extends ProjectCommand {
             serviceName: flags.serviceName,
             graphVariant,
             graphName: config.name,
+            warnings,
             errors,
             updatedGateway
           };