Commit 1edeb36
authored
Resolve missing types "Boolean", "String" (#1355)
A change to buildClientSchema removed some behavior that we
depended on. Previously, with caching in place, basic types
(Boolean, String, ...) were returned even if they didn't exist
in typeMap. The "fix" was itself a breaking change, adding basic
types that weren't previously added to the typeMap.
Full discussion here: graphql/graphql-js@183ff32#r32971387
This commit addresses a couple issues:
1) Request the built in types from Engine
2) Disallow versions of graphql that include the broken fix
The broken fix causes a regression for service:push. During the
broken fix (graphql@14.2.1 - 14.3.0), ALL built in types are included
during buildClientSchema (even if they're not part of the schema).
This causes a hash mismatch between the pushed schema and the
schema hash that Apollo Server recognizes.1 parent ad3676b commit 1edeb36
5 files changed
Lines changed: 10 additions & 18 deletions
File tree
- packages
- apollo-language-server
- src/providers/schema
- apollo
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
Lines changed: 2 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
| 4 | + | |
13 | 5 | | |
14 | 6 | | |
15 | 7 | | |
| |||
101 | 93 | | |
102 | 94 | | |
103 | 95 | | |
104 | | - | |
| 96 | + | |
105 | 97 | | |
106 | 98 | | |
107 | 99 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
0 commit comments