Append terminating newline to output

Author: michaelnisi

CHANGELOG.md

@@ -3,15 +3,15 @@
 ## Upcoming
 
 - `apollo`
-  - <First `apollo` related entry goes here>
+  - Introduce terminator parameter to `writeGeneratedFiles` function [#1226](https://github.com/apollographql/apollo-tooling/pull/1226)
 - `apollo-codegen-core`
   - <First `apollo-codegen-core` related entry goes here>
 - `apollo-codegen-flow`
   - <First `apollo-codegen-flow` related entry goes here>
 - `apollo-codegen-scala`
   - <First `apollo-codegen-scala` related entry goes here>
 - `apollo-codegen-swift`
-  - <First `apollo-codegen-swift` related entry goes here>
+  - Append terminating newline character to generated files [#531](https://github.com/apollographql/apollo-ios/issues/531)
 - `apollo-codegen-typescript`
   - <First `apollo-codegen-typescript` related entry goes here>
 - `apollo-env`

packages/apollo/src/commands/client/__tests__/__snapshots__/generate.test.ts.snap

@@ -184,7 +184,8 @@ public final class SimpleQueryQuery: GraphQLQuery {
       }
     }
   }
-}"
+}
+"
 `;
 
 exports[`client:codegen writes swift types from local schema in a graphql file 1`] = `
@@ -225,7 +226,8 @@ public final class SimpleQueryQuery: GraphQLQuery {
       }
     }
   }
-}"
+}
+"
 `;
 
 exports[`client:codegen writes types for query with only client-side data 1`] = `

packages/apollo/src/generate.ts

@@ -73,10 +73,10 @@ export default function generate(
     const generator = generateSwiftSource(context, outputIndividualFiles, only);
 
     if (outputIndividualFiles) {
-      writeGeneratedFiles(generator.generatedFiles, outputPath);
+      writeGeneratedFiles(generator.generatedFiles, outputPath, "\n");
       writtenFiles += Object.keys(generator.generatedFiles).length;
     } else {
-      fs.writeFileSync(outputPath, generator.output);
+      fs.writeFileSync(outputPath, generator.output.concat("\n"));
       writtenFiles += 1;
     }
 
@@ -215,12 +215,13 @@ export default function generate(
 
 function writeGeneratedFiles(
   generatedFiles: { [fileName: string]: BasicGeneratedFile },
-  outputDirectory: string
+  outputDirectory: string,
+  terminator: string = ""
 ) {
   for (const [fileName, generatedFile] of Object.entries(generatedFiles)) {
     fs.writeFileSync(
       path.join(outputDirectory, fileName),
-      generatedFile.output
+      generatedFile.output.concat(terminator)
     );
   }
 }