Revert "Restore skipSSLValidation flag"

This reverts commit 7e9aad1.

Accidental push to master branch

Author: trevor-scheer

packages/apollo-language-server/src/schema/providers/introspection.ts

@@ -10,8 +10,10 @@ import {
   IntrospectionQuery,
   parse
 } from "graphql";
-import { Agent } from "http";
+import { Agent, AgentOptions } from "https";
 import { fetch } from "apollo-env";
+import { URL } from "url";
+
 import { RemoteServiceConfig } from "../../config";
 import { GraphQLSchemaProvider, SchemaChangeUnsubscribeHandler } from "./base";
 
@@ -21,11 +23,23 @@ export class IntrospectionSchemaProvider implements GraphQLSchemaProvider {
   async resolveSchema() {
     if (this.schema) return this.schema;
     const { skipSSLValidation, url, headers } = this.config;
-    const options: HttpLink.Options = {
-      uri: url,
-      fetch,
-      ...(skipSSLValidation && { fetchOptions: { agent: new Agent() } })
-    };
+    let options: HttpLink.Options = { uri: url, fetch };
+
+    if (skipSSLValidation) {
+      const urlObject = new URL(url);
+      const host = urlObject.host;
+      const port = +urlObject.port || 443;
+
+      const agentOptions: AgentOptions = {
+        host: host,
+        port: port,
+        rejectUnauthorized: false
+      };
+
+      const agent = new Agent(agentOptions);
+
+      options.fetchOptions = { agent: agent };
+    }
 
     const { data, errors } = (await toPromise(
       linkExecute(createHttpLink(options), {

packages/apollo/src/Command.ts

@@ -35,7 +35,6 @@ export interface Flags {
   engine?: string;
   frontend?: string;
   tag?: string;
-  skipSSLValidation?: boolean;
 }
 
 const headersArrayToObject = (
@@ -134,8 +133,7 @@ export abstract class ProjectCommand extends Command {
         service: {
           endpoint: {
             url: flags.endpoint,
-            headers: headersArrayToObject(flags.header),
-            ...(flags.skipSSLValidation && { skipSSLValidation: true })
+            headers: headersArrayToObject(flags.header)
           }
         }
       });

packages/apollo/src/commands/service/download.ts

@@ -14,10 +14,6 @@ export default class ServiceDownload extends ProjectCommand {
       char: "t",
       description: "The published tag to check this service against",
       default: "current"
-    }),
-    skipSSLValidation: flags.boolean({
-      char: "k",
-      description: "Allow connections to an SSL site without certs"
     })
   };