[AR-1691] The CLI does not need to know the frontend URL

Currently the CLI has configuration (via `engine.frontend` in a config file or
the --frontend flag to a few commands) to control what Engine frontend the user
is using. This is primarily set by Apollo employees using staging servers. This
is in addition to setting `engine.endpoint` to control which GraphQL server it
talks to.

This is used for two things:
- passing arguments to a couple ServiceMutation fields
- printing links in `services:list`

As of recently, this no longer is needed:
- those ServiceMutation fields now ignore the `frontend` argument and just use
  the correct frontend for the server processing them
- we expose a Query.frontendUrlRoot field that `services:list` can use

So this change completely removes recognition of this config field as well as
the flag. (Note that it is not an error to have unrecognized fields in your
config file, though it is to pass an unknown flag.) While this is technically
backwards-incompatible, we don't expect that this undocumented feature is used
much other than by Apollo employees.

Author: glasser

apollo.config.js

@@ -6,7 +6,6 @@ module.exports = {
     excludes: ["**/*.test.ts", "**/__tests__/*"]
   },
   engine: {
-    frontend: "https://engine-staging.apollographql.com",
     endpoint: "https://engine-staging-graphql.apollographql.com/api/graphql"
   }
 };

packages/apollo-language-server/src/config/__tests__/config.ts

@@ -78,8 +78,7 @@ describe("ApolloConfig", () => {
       const config = new ApolloConfig({});
       const overrides = {
         engine: {
-          endpoint: "https://test.apollographql.com/api/graphql",
-          frontend: "https://test.apollographql.com"
+          endpoint: "https://test.apollographql.com/api/graphql"
         }
       };
       config.setDefaults(overrides);

packages/apollo-language-server/src/config/__tests__/loadConfig.ts

@@ -111,7 +111,6 @@ describe("loadConfig", () => {
           },
           "engine": Object {
             "endpoint": "https://engine-graphql.apollographql.com/api/graphql",
-            "frontend": "https://engine.apollographql.com",
           },
         }
       `);
@@ -136,7 +135,6 @@ describe("loadConfig", () => {
         Object {
           "engine": Object {
             "endpoint": "https://engine-graphql.apollographql.com/api/graphql",
-            "frontend": "https://engine.apollographql.com",
           },
           "service": Object {
             "endpoint": Object {

packages/apollo-language-server/src/config/config.ts

@@ -33,13 +33,11 @@ export interface LocalServiceConfig {
 
 export interface EngineConfig {
   endpoint?: EndpointURI;
-  frontend?: EndpointURI;
   readonly apiKey?: string;
 }
 
 export const DefaultEngineConfig = {
-  endpoint: "https://engine-graphql.apollographql.com/api/graphql",
-  frontend: "https://engine.apollographql.com"
+  endpoint: "https://engine-graphql.apollographql.com/api/graphql"
 };
 
 export const DefaultConfigBase = {

packages/apollo-language-server/src/engine/index.ts

@@ -98,7 +98,7 @@ export class ApolloEngineClient extends GraphQLDataSource {
       if (!(data && data.service)) {
         throw new Error("Error in request from Apollo Graph Manager");
       }
-      return data.service;
+      return data;
     });
   }
 

packages/apollo-language-server/src/engine/operations/checkPartialSchema.ts

@@ -8,7 +8,6 @@ export const CHECK_PARTIAL_SCHEMA = gql`
     $partialSchema: PartialSchemaInput!
     $gitContext: GitContextInput
     $historicParameters: HistoricQueryParameters
-    $frontend: String
   ) {
     service(id: $id) {
       checkPartialSchema(
@@ -17,7 +16,6 @@ export const CHECK_PARTIAL_SCHEMA = gql`
         partialSchema: $partialSchema
         gitContext: $gitContext
         historicParameters: $historicParameters
-        frontend: $frontend
       ) {
         compositionValidationResult {
           compositionValidationDetails {

packages/apollo-language-server/src/engine/operations/checkSchema.ts

@@ -8,7 +8,6 @@ export const CHECK_SCHEMA = gql`
     $tag: String
     $gitContext: GitContextInput
     $historicParameters: HistoricQueryParameters
-    $frontend: String
   ) {
     service(id: $id) {
       checkSchema(
@@ -17,7 +16,6 @@ export const CHECK_SCHEMA = gql`
         baseSchemaTag: $tag
         gitContext: $gitContext
         historicParameters: $historicParameters
-        frontend: $frontend
       ) {
         targetUrl
         diffToPrevious {

packages/apollo-language-server/src/engine/operations/listServices.ts

@@ -2,6 +2,7 @@ import gql from "graphql-tag";
 
 export const LIST_SERVICES = gql`
   query ListServices($id: ID!, $graphVariant: String!) {
+    frontendUrlRoot
     service(id: $id) {
       implementingServices(graphVariant: $graphVariant) {
         __typename

packages/apollo-language-server/src/graphqlTypes.ts

@@ -166,7 +166,6 @@ export interface CheckPartialSchemaVariables {
   partialSchema: PartialSchemaInput;
   gitContext?: GitContextInput | null;
   historicParameters?: HistoricQueryParameters | null;
-  frontend?: string | null;
 }
 
 /* tslint:disable */
@@ -296,7 +295,6 @@ export interface CheckSchemaVariables {
   tag?: string | null;
   gitContext?: GitContextInput | null;
   historicParameters?: HistoricQueryParameters | null;
-  frontend?: string | null;
 }
 
 /* tslint:disable */
@@ -355,6 +353,7 @@ export interface ListServices_service {
 }
 
 export interface ListServices {
+  frontendUrlRoot: string;
   /**
    * Service by ID
    */

packages/apollo/src/Command.ts

@@ -35,7 +35,6 @@ export interface Flags {
   localSchemaFile?: string;
   key?: string;
   engine?: string;
-  frontend?: string;
   tag?: string;
   variant?: string;
   graph?: string;
@@ -89,10 +88,6 @@ export abstract class ProjectCommand extends Command {
     engine: flags.string({
       description: "URL for a custom Apollo Graph Manager deployment",
       hidden: true
-    }),
-    frontend: flags.string({
-      description: "URL for a custom Apollo Graph Manager frontend",
-      hidden: true
     })
   };
 
@@ -161,8 +156,7 @@ export abstract class ProjectCommand extends Command {
     config.setDefaults({
       engine: {
         apiKey: flags.key,
-        endpoint: flags.engine,
-        frontend: flags.frontend
+        endpoint: flags.engine
       }
     });