update checks operation to match new schema

Author: JakeDawkins

packages/apollo-language-server/src/engine/operations/checkPartialSchema.ts

@@ -13,7 +13,7 @@ export const CHECK_PARTIAL_SCHEMA = gql`
         implementingServiceName: $implementingServiceName
         partialSchema: $partialSchema
       ) {
-        compositionConfig {
+        compositionValidationDetails {
           schemaHash
         }
         errors {
@@ -22,7 +22,6 @@ export const CHECK_PARTIAL_SCHEMA = gql`
         warnings {
           message
         }
-        didUpdateGateway: updatedGateway
       }
     }
   }

packages/apollo-language-server/src/graphqlTypes.ts

@@ -6,8 +6,8 @@
 // GraphQL mutation operation: CheckPartialSchema
 // ====================================================
 
-export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionConfig {
-  __typename: "CompositionConfig";
+export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionValidationDetails {
+  __typename: "CompositionValidationDetails";
   /**
    * Hash of the composed schema
    */
@@ -25,11 +25,13 @@ export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingS
 }
 
 export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph {
-  __typename: "CompositionResult";
+  __typename: "CompositionValidationResult";
   /**
-   * The produced composition config. Will be null if there are any errors
+   * Akin to a composition config, represents the partial schemas and implementing services that were used
+   * in running composition. Will be null if any errors are encountered. Also may contain a schema hash if
+   * one could be computed, which can be used for schema validation.
    */
-  compositionConfig: CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionConfig | null;
+  compositionValidationDetails: CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionValidationDetails | null;
   /**
    * List of errors during composition. Errors mean that Apollo was unable to compose the
    * graph's implementing services into a GraphQL schema. This partial schema should not be
@@ -44,21 +46,17 @@ export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingS
    * in its composition result will result in updating the composition config.
    */
   warnings: (CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_warnings | null)[];
-  /**
-   * Whether the gateway link was updated.
-   */
-  didUpdateGateway: boolean;
 }
 
 export interface CheckPartialSchema_service {
   __typename: "ServiceMutation";
   /**
    * This mutation will not result in any changes to the implementing service
-   *
+   * 
    * Run composition with the Implementing Service's partial schema replaced with the one provided
    * in the mutation's input. Store the composed schema, return the hash of the composed schema,
    * and any warnings and errors pertaining to composition.
-   *
+   * 
    * This mutation will not run validation against operations.
    */
   validatePartialSchemaOfImplementingServiceAgainstGraph: CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph;
@@ -167,11 +165,11 @@ export interface CheckSchema_service {
   /**
    * Validate, diff, and store a schema so the diff can be viewed by users in the UI.
    * This mutation will not mark the schema as "published".
-   *
+   * 
    * One of "proposedSchema" or "proposedSchemaHash" must be provided.
    * If both are provided, the computed schema hash will be compared with the input hash,
    * an error will be returned if the hashes don't match.
-   *
+   * 
    * If the "proposedSchemaHash" is specified, the already stored schema will be loaded.
    */
   checkSchema: CheckSchema_service_checkSchema;
@@ -222,19 +220,15 @@ export interface RegisterOperationsVariables {
 // GraphQL mutation operation: RemoveServiceAndCompose
 // ====================================================
 
-export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition_compositionConfig_implementingServices {
-  __typename: "FederatedImplementingService";
+export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition_compositionConfig_implementingServiceLocations {
+  __typename: "ImplementingServiceLocation";
   /**
-   * Identifies which graph this implementing service belongs to.
-   * Formerly known as "service_id"
+   * The name of the implementing service
    */
-  graphID: string;
+  name: string;
   /**
-   * Specifies which variant of a graph this implementing service belongs to".
-   * Formerly known as "tag"
+   * The path in storage to access the implementing service config file
    */
-  graphVariant: string;
-  name: string;
   path: string;
 }
 
@@ -243,7 +237,7 @@ export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTri
   /**
    * List of implementing services that comprise a composed graph
    */
-  implementingServices: RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition_compositionConfig_implementingServices[];
+  implementingServiceLocations: RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition_compositionConfig_implementingServiceLocations[];
 }
 
 export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition_errors_location {
@@ -271,7 +265,7 @@ export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTri
 }
 
 export interface RemoveServiceAndCompose_service_removeImplementingServiceAndTriggerComposition {
-  __typename: "CompositionResult";
+  __typename: "CompositionAndRemoveResult";
   /**
    * The produced composition config. Will be null if there are any errors
    */
@@ -488,10 +482,10 @@ export interface UploadAndComposePartialSchema_service {
   /**
    * Creates or updates an implementing service of a given "name" on the graph variant, then
    * updates the graph variant's composition configs/artifacts to reflect these changes.
-   *
+   * 
    * An enriched SDL of the implementing service can be uploaded
    * via "implementingServiceConfiguration.partialSchema.partialSchemaSDL".
-   *
+   * 
    * Alternatively, previously uploaded partial schema could be re-associated with the
    * implementing service via "implementingServiceConfiguration.partialSchema.partialSchemaHash".
    */
@@ -1695,10 +1689,10 @@ export interface OperationDocumentInput {
 /**
  * Input for registering a partial schema to an implementing service.
  * One of the fields must be specified (validated server-side).
- *
+ * 
  * If a new partialSchemaSDL is passed in, this operation will store it before
  * creating the association.
- *
+ * 
  * If both the sdl and hash are specified, an error will be thrown if the provided
  * hash doesn't match our hash of the sdl contents
  */

packages/apollo/src/commands/service/check.ts

@@ -266,8 +266,7 @@ export default class ServiceCheck extends ProjectCommand {
                  */
                 const {
                   errors,
-                  warnings,
-                  compositionConfig
+                  warnings
                 } = await project.engine.checkPartialSchema({
                   id: config.name,
                   graphVariant: config.tag,