Improve typing in code generator

Author: shadaj

packages/apollo-codegen-scala/src/codeGeneration.ts

@@ -443,7 +443,10 @@ function dataContainerDeclaration(
     insideCompanion
   }: {
     name: string;
-    properties: (Property & ({ name: string } | { responseName: string }))[];
+    properties: (Property & {
+      name?: string;
+      responseName?: string;
+    })[];
     extraSuperClasses?: string[];
     description?: string;
     insideCompanion?: () => void;
@@ -460,7 +463,7 @@ function dataContainerDeclaration(
     () => {
       properties.forEach(p => {
         propertyDeclaration(generator, {
-          jsName: (p as any).name || (p as any).responseName,
+          jsName: p.name || p.responseName,
           propertyName: p.propertyName,
           typeName: p.typeName
         });
@@ -490,12 +493,7 @@ function dataContainerDeclaration(
         },
         () => {
           const propertiesIn = properties
-            .map(
-              p =>
-                `"${(p as any).name || (p as any).responseName}" -> ${
-                  p.propertyName
-                }`
-            )
+            .map(p => `"${p.name || p.responseName}" -> ${p.propertyName}`)
             .join(", ");
           generator.printOnNewline(
             `scala.scalajs.js.Dynamic.literal(${propertiesIn}).asInstanceOf[${name}]`
@@ -542,12 +540,7 @@ function dataContainerDeclaration(
           },
           () => {
             const propertiesIn = properties
-              .map(
-                p =>
-                  `"${(p as any).name || (p as any).responseName}" -> ${
-                    p.propertyName
-                  }`
-              )
+              .map(p => `"${p.name || p.responseName}" -> ${p.propertyName}`)
               .join(", ");
             generator.printOnNewline(
               `scala.scalajs.js.Dynamic.literal(${propertiesIn}).asInstanceOf[${name}]`