Add ability to define schema download output path that doesn't exist yet (#1807)

* ability to define output path that don't exist yet

* update changelog

* update package-lock

Author: JakeDawkins

CHANGELOG.md

@@ -4,8 +4,9 @@
 
 - `apollo`
   - Update shortlinks to use go.apollo.dev instead of bitly [#1790](https://github.com/apollographql/apollo-tooling/pull/1790)
-  - Support disabling literal stripping when extracting queries. [1703](https://github.com/apollographql/apollo-tooling/pull/1703)
   - Fix rendering of unexpected composition errors throwing a table cell error [#1806](https://github.com/apollographql/apollo-tooling/pull/1806)
+  - Support disabling literal stripping when extracting queries. [1703](https://github.com/apollographql/apollo-tooling/pull/1703)
+  - Add ability to define schema download output path that doesn't exist yet [#1807](https://github.com/apollographql/apollo-tooling/pull/1807)
 - `apollo-codegen-flow`
   - Add @generated comment
 - `apollo-codegen-scala`

package-lock.json

@@ -70,6 +70,7 @@
     "@types/lodash.pickby": "4.6.6",
     "@types/lodash.sortby": "4.7.6",
     "@types/minimatch": "3.0.3",
+    "@types/mkdirp": "^1.0.0",
     "@types/nock": "10.0.3",
     "@types/node": "8.10.56",
     "@types/node-fetch": "2.5.4",

package.json

@@ -59,6 +59,7 @@
     "listr": "0.14.3",
     "lodash.identity": "3.0.0",
     "lodash.pickby": "4.6.0",
+    "mkdirp": "^1.0.3",
     "moment": "2.24.0",
     "strip-ansi": "5.2.0",
     "table": "5.4.6",

packages/apollo/package.json

@@ -1,8 +1,8 @@
-import { flags } from "@oclif/command";
 import { introspectionFromSchema, printSchema } from "graphql";
-import { writeFileSync } from "fs";
-
 import { ClientCommand } from "../../Command";
+import mkdirp from "mkdirp";
+import fs from "fs";
+import { dirname as getDirName } from "path";
 
 export default class SchemaDownload extends ClientCommand {
   static description =
@@ -23,8 +23,6 @@ export default class SchemaDownload extends ClientCommand {
   ];
 
   async run() {
-    let result;
-    let gitContext;
     await this.runTasks(({ args, project, flags }) => {
       const extension = args.output.split(".").pop();
       const isSDLFormat = ["graphql", "graphqls", "gql"].includes(extension);
@@ -36,7 +34,13 @@ export default class SchemaDownload extends ClientCommand {
             const formattedSchema = isSDLFormat
               ? printSchema(schema)
               : JSON.stringify(introspectionFromSchema(schema), null, 2);
-            writeFileSync(args.output, formattedSchema);
+
+            try {
+              await mkdirp(getDirName(args.output));
+              fs.writeFileSync(args.output, formattedSchema);
+            } catch (err) {
+              throw err;
+            }
           }
         }
       ];

packages/apollo/src/commands/client/download-schema.ts

@@ -1,8 +1,10 @@
 import { flags } from "@oclif/command";
 import { introspectionFromSchema } from "graphql";
-import { writeFileSync } from "fs";
 import chalk from "chalk";
 import { ProjectCommand } from "../../Command";
+import mkdirp from "mkdirp";
+import fs from "fs";
+import { dirname as getDirName } from "path";
 
 export default class ServiceDownload extends ProjectCommand {
   static aliases = ["schema:download"];
@@ -24,22 +26,22 @@ export default class ServiceDownload extends ProjectCommand {
   static args = [
     {
       name: "output",
-      description: "Path to write the introspection result to",
+      description:
+        "Path to write the introspection result to. Supports .json output only.",
       required: true,
       default: "schema.json"
     }
   ];
 
   async run() {
-    let result;
-    let gitContext;
     await this.runTasks(({ args, project, flags }) => [
       {
         title: `Saving schema to ${args.output}`,
         task: async () => {
           try {
             const schema = await project.resolveSchema({ tag: flags.tag });
-            writeFileSync(
+            await mkdirp(getDirName(args.output));
+            fs.writeFileSync(
               args.output,
               JSON.stringify(introspectionFromSchema(schema), null, 2)
             );