Skip to content

Commit c4f9e9e

Browse files
committed
update snapshots and variables for format tests
1 parent e7ba9be commit c4f9e9e

2 files changed

Lines changed: 18 additions & 12 deletions

File tree

packages/apollo/src/commands/service/__tests__/__snapshots__/check.test.ts.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ PASS FIELD_REMOVED \`Change.affectedClientIdVersionPairs\` was r
2222
PASS FIELD_REMOVED \`Change.affectedClientReferenceIds\` was removed
2323
PASS FIELD_REMOVED \`SchemaDiff.numberOfCheckedOperations\` was removed
2424
25-
View full details at: https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z"
25+
View full details at: https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z?graphCompositionId=fff"
2626
`;
2727

2828
exports[`service:check formatHumanReadable should have correct output with only breaking changes 1`] = `
@@ -35,14 +35,14 @@ FAIL FIELD_REMOVED \`Change.affectedClients\` was removed
3535
FAIL FIELD_REMOVED \`NamedIntrospectionValue.printedType\` was removed
3636
FAIL TYPE_REMOVED \`NamedIntrospectionArg\` removed
3737
38-
View full details at: https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z"
38+
View full details at: https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z?graphCompositionId=fff"
3939
`;
4040

4141
exports[`service:check formatHumanReadable should have correct output with only non-breaking changes 1`] = `
4242
"
4343
No changes present between schemas
4444
45-
View full details at: https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z"
45+
View full details at: https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z?graphCompositionId=fff"
4646
`;
4747

4848
exports[`service:check integration federated should report composition errors correctly --json 1`] = `
@@ -272,7 +272,7 @@ exports[`service:check markdown formatting is correct with breaking changes 1`]
272272
🔢 Compared **18 schema changes** against **100 operations** seen over the **last 24 hours**.
273273
❌ Found **7 breaking changes** that would affect **3 operations** across **2 clients**
274274
275-
🔗 [View your service check details](https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z).
275+
🔗 [View your service check details](https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z?graphCompositionId=fff).
276276
"
277277
`;
278278

@@ -283,7 +283,7 @@ exports[`service:check markdown formatting is correct with breaking changes 2`]
283283
🔢 Compared **1 schema change** against **1 operation** seen over the **last 24 hours**.
284284
❌ Found **1 breaking change** that would affect **1 operation** across **1 client**
285285
286-
🔗 [View your service check details](https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z).
286+
🔗 [View your service check details](https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z?graphCompositionId=fff).
287287
"
288288
`;
289289

@@ -294,6 +294,6 @@ exports[`service:check markdown formatting is correct with no breaking changes 1
294294
🔢 Compared **0 schema changes** against **100 operations** seen over the **last 24 hours**.
295295
✅ Found **no breaking changes**.
296296
297-
🔗 [View your service check details](https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z).
297+
🔗 [View your service check details](https://engine-dev.apollographql.com/service/engine/checks?schemaTag=Detached%3A%20d664f715645c5f0bb5ad4f2260cd6cb8d19bbc68&schemaTagId=f9f68e7e-1b5f-4eab-a3da-1fd8cd681111&from=2019-03-26T22%3A25%3A12.887Z?graphCompositionId=fff).
298298
"
299299
`;

packages/apollo/src/commands/service/__tests__/check.test.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,8 @@ describe("service:check", () => {
599599
formatMarkdown({
600600
graphName: "engine",
601601
tag: "staging",
602-
checkSchemaResult
602+
checkSchemaResult,
603+
graphCompositionID: "fff"
603604
})
604605
).toMatchSnapshot();
605606
// Check when all the values are singluar
@@ -624,7 +625,8 @@ describe("service:check", () => {
624625
],
625626
numberOfCheckedOperations: 1
626627
}
627-
}
628+
},
629+
graphCompositionID: "fff"
628630
})
629631
).toMatchSnapshot();
630632
});
@@ -643,7 +645,8 @@ describe("service:check", () => {
643645
affectedQueries: [],
644646
changes: []
645647
}
646-
}
648+
},
649+
graphCompositionID: "fff"
647650
})
648651
).toMatchSnapshot();
649652
});
@@ -675,7 +678,8 @@ describe("service:check", () => {
675678
it("should have correct output with breaking and non-breaking changes", () => {
676679
expect(
677680
formatHumanReadable({
678-
checkSchemaResult
681+
checkSchemaResult,
682+
graphCompositionID: "fff"
679683
})
680684
).toMatchSnapshot();
681685
});
@@ -691,7 +695,8 @@ describe("service:check", () => {
691695
affectedQueries: [],
692696
changes: []
693697
}
694-
}
698+
},
699+
graphCompositionID: "fff"
695700
})
696701
).toMatchSnapshot();
697702
});
@@ -709,7 +714,8 @@ describe("service:check", () => {
709714
change => change.severity === ChangeSeverity.FAILURE
710715
)
711716
}
712-
}
717+
},
718+
graphCompositionID: "fff"
713719
})
714720
).toMatchSnapshot();
715721
});

0 commit comments

Comments
 (0)