Skip to content

Commit df384df

Browse files
hwillsonabernix
authored andcommitted
Add event-stream as a dep and lock it (security issue) (#739)
As identified in dominictarr/event-stream#116, `event-stream` has a major security issue (malware injection) in version 3.3.6 (thanks to `flatmap-stream` version 0.1.1). `event-stream` 3.3.6 is referenced as a child dep in this project, through `tsc-watch` and `vscode-apollo` / `vscode`. ![screenshot 2018-11-26 13 53 19](https://user-images.githubusercontent.com/137740/49037391-18e04f80-f188-11e8-9eeb-f26f88c372ab.png) This commit adds `event-stream` as a top level dependency, and locks it to the most recent version that excludes `flatmap-stream` (version 3.3.4). This should work for now, but ultimately `tsc-watch` and `vscode` should be updated to newer versions, that address this issue (since their child deps are the problem). Both projects have yet to submit fixes to this problem.
1 parent 6786a94 commit df384df

2 files changed

Lines changed: 29 additions & 24 deletions

File tree

package-lock.json

Lines changed: 28 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
"apollo-codegen-typescript": "file:packages/apollo-codegen-typescript",
4343
"apollo-env": "file:packages/apollo-env",
4444
"apollo-language-server": "file:packages/apollo-language-server",
45+
"event-stream": "=3.3.4",
4546
"vscode-apollo": "file:packages/vscode-apollo",
4647
"webpack-command": "^0.4.1"
4748
},

0 commit comments

Comments
 (0)