Use reference-equality when filtering rules in buildSchemaFromSDL#1551
Merged
trevor-scheer merged 2 commits intomasterfrom Oct 2, 2019
Merged
Conversation
Similar in spirit to apollographql/apollo-server#3338. The technique previously used for removing rules from the standard `specifiedRules` was leveraging a check on `Function.prototype.name`, rather than doing direct object equality. While that does generally work, thanks to the more recent standardization of `Function.prototype.name`, it still breaks down under some of the more aggressive minification techniques since a function's name is not guaranteed to remain the same. Fixes: apollographql/apollo-server#3335
trevor-scheer
approved these changes
Sep 30, 2019
Member
Author
|
|
abernix
changed the title
buildSchemaFromSDLbuildSchemaFromSDL
abernix
deleted the
abernix/avoid-checking-graphql-rules-by-Function.prototype.name
branch
4 tasks
Member
|
This change broke the ability to use I recognize that the peer dep from |
Contributor
|
@glasser thank you for pointing this out. Is this an issue that So I understand correctly, is it accurate to say that |
Member
|
I believe so. |
trevor-scheer
added a commit
to apollographql/apollo-server
that referenced
this pull request
Oct 7, 2019
This commit updates the apollo-graphql package to the latest version. This includes a fix for a bug that currently breaks minification. For reference, see: apollographql/apollo-tooling#1551 Fixes #3335
abernix
pushed a commit
to apollographql/apollo-server
that referenced
this pull request
Oct 8, 2019
This commit updates the apollo-graphql package to the latest version. This includes a fix for a bug that currently breaks minification. For reference, see: apollographql/apollo-tooling#1551 Fixes #3335
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…3387) This commit updates the apollo-graphql package to the latest version. This includes a fix for a bug that currently breaks minification. For reference, see: apollographql/apollo-tooling#1551 Fixes apollographql/apollo-server#3335 Apollo-Orig-Commit-AS: apollographql/apollo-server@6a4b681
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar in spirit to apollographql/apollo-server#3338.
The technique previously used for removing rules from the standard
specifiedRuleswas leveraging a check onFunction.prototype.name, rather than doing direct object equality. While that does generally work, thanks to the more recent standardization ofFunction.prototype.name, it still breaks down under some of the more aggressive minification techniques since a function's name is not guaranteed to remain the same.Fixes: apollographql/apollo-server#3335