From 24a7804264c04bef612d7c1196da3d4626075368 Mon Sep 17 00:00:00 2001 From: Nikola Irinchev Date: Mon, 3 Dec 2018 12:36:46 +0100 Subject: [PATCH 1/3] Pass correct headers to Client Project --- packages/apollo/src/Command.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/apollo/src/Command.ts b/packages/apollo/src/Command.ts index f2e8b90dc6..30ecdc154e 100644 --- a/packages/apollo/src/Command.ts +++ b/packages/apollo/src/Command.ts @@ -264,7 +264,7 @@ export abstract class ClientCommand extends ProjectCommand { if (flags.endpoint) { config.client.service = { url: flags.endpoint, - headers: headersArrayToObject(flags.headers) + headers: headersArrayToObject(flags.header) }; } From af2fddd6d491d0da6a1e9da7e0fc6668bd30b3cc Mon Sep 17 00:00:00 2001 From: Nikola Irinchev Date: Mon, 3 Dec 2018 12:49:37 +0100 Subject: [PATCH 2/3] Fix header parsing --- packages/apollo/src/Command.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/apollo/src/Command.ts b/packages/apollo/src/Command.ts index 30ecdc154e..a822519d7a 100644 --- a/packages/apollo/src/Command.ts +++ b/packages/apollo/src/Command.ts @@ -59,8 +59,10 @@ export abstract class ProjectCommand extends Command { header: flags.string({ multiple: true, parse: header => { - const [key, value] = header.split(":"); - return JSON.stringify({ [key.trim()]: value.trim() }); + const separatorIndex = header.indexOf(":"); + const key = header.substring(0, separatorIndex).trim();; + const value = header.substring(separatorIndex + 1).trim(); + return JSON.stringify({ [key]: value }); }, description: "Additional headers to send to server for introspectionQuery" }), From 932ad437d7efaa35112f4d4741d061461d06cf7b Mon Sep 17 00:00:00 2001 From: Nikola Irinchev Date: Mon, 3 Dec 2018 13:25:41 +0100 Subject: [PATCH 3/3] Remove the extra semicolon --- packages/apollo/src/Command.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/apollo/src/Command.ts b/packages/apollo/src/Command.ts index a822519d7a..b9d7ea527f 100644 --- a/packages/apollo/src/Command.ts +++ b/packages/apollo/src/Command.ts @@ -60,7 +60,7 @@ export abstract class ProjectCommand extends Command { multiple: true, parse: header => { const separatorIndex = header.indexOf(":"); - const key = header.substring(0, separatorIndex).trim();; + const key = header.substring(0, separatorIndex).trim(); const value = header.substring(separatorIndex + 1).trim(); return JSON.stringify({ [key]: value }); },