From a45183be569d2fc0129704bf08e7fdefc453db52 Mon Sep 17 00:00:00 2001 From: Shahbaz Nazir Date: Wed, 10 May 2023 19:17:40 +0500 Subject: [PATCH 1/4] fix: Permissions for ghcr --- .github/workflows/deploy.yaml | 11 ++++++++++- .github/workflows/release.yaml | 9 +++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml index 9f90d32a..3ec91892 100644 --- a/.github/workflows/deploy.yaml +++ b/.github/workflows/deploy.yaml @@ -8,6 +8,8 @@ jobs: release-dev: name: Release Dev runs-on: ubuntu-latest + permissions: + packages: write steps: - name: Checkout @@ -32,11 +34,18 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v2 + - name: Login to GHCR + uses: docker/login-action@v2 + with: + registry: ghcr.io + username: ${{ github.actor }} + password: ${{ secrets.GITHUB_TOKEN }} + - name: GoReleaser run: make release env: GORELEASER_SKIP_VALIDATE: true - GITHUB_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} deploy-titus: runs-on: ubuntu-latest diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 1ba3ad45..98531c2a 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -8,6 +8,8 @@ jobs: release: name: Release runs-on: ubuntu-latest + permissions: + packages: write steps: - name: Checkout @@ -26,6 +28,13 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v2 + - name: Login to GHCR + uses: docker/login-action@v2 + with: + registry: ghcr.io + username: github-actions-bot + password: ${{ secrets.GH_ACCESS_TOKEN }} + - name: GoReleaser run: make release env: From 27328f7acb1f46897c312a42b830ee02ce0ab5ea Mon Sep 17 00:00:00 2001 From: Shahbaz Nazir Date: Wed, 10 May 2023 19:19:04 +0500 Subject: [PATCH 2/4] fix --- .github/workflows/release.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 98531c2a..5ad10401 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -32,11 +32,11 @@ jobs: uses: docker/login-action@v2 with: registry: ghcr.io - username: github-actions-bot - password: ${{ secrets.GH_ACCESS_TOKEN }} + username: ${{ github.actor }} + password: ${{ secrets.GITHUB_TOKEN }} - name: GoReleaser run: make release env: RELEASE: true - GITHUB_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 1852044594c5092b7a76f48161a62bc7c4faa507 Mon Sep 17 00:00:00 2001 From: Shahbaz Nazir Date: Wed, 10 May 2023 19:20:57 +0500 Subject: [PATCH 3/4] fix: remove explicit permissions --- .github/workflows/deploy.yaml | 2 -- .github/workflows/release.yaml | 2 -- 2 files changed, 4 deletions(-) diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml index 3ec91892..8354561f 100644 --- a/.github/workflows/deploy.yaml +++ b/.github/workflows/deploy.yaml @@ -8,8 +8,6 @@ jobs: release-dev: name: Release Dev runs-on: ubuntu-latest - permissions: - packages: write steps: - name: Checkout diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 5ad10401..680cae84 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -8,8 +8,6 @@ jobs: release: name: Release runs-on: ubuntu-latest - permissions: - packages: write steps: - name: Checkout From 85a4379f8611f15e8c1ad5bb55dfd3e787fba314 Mon Sep 17 00:00:00 2001 From: Shahbaz Nazir Date: Wed, 10 May 2023 19:23:59 +0500 Subject: [PATCH 4/4] freakin changelog again --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1206f2a3..d6973824 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -57,7 +57,8 @@ Contains all the PRs that improved the code without changing the behaviours. - [#365](https://github.com/archway-network/archway/pull/356) - x/rewards genesis runs before x/genutil to correctly process genesis txs. - [#366](https://github.com/archway-network/archway/pull/366) - github actions should fetch tags as well -- [#368](https://github.com/archway-network/archway/pull/368) - github actions should fetch tags as well for deploy workflwo +- [#368](https://github.com/archway-network/archway/pull/368) - github actions should fetch tags as well for deploy workflow +- [#370](https://github.com/archway-network/archway/pull/370) - login to ghcr ### Changed