fix: coerce enum directive arguments to internal values when printing (#8117)

* fix: coerce enum directive arguments to internal values when printing schema

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* Fix error

* changest

* ..

* lets go

---------

Signed-off-by: Matt Krick <matt.krick@gmail.com>
Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>

Author: mattkrick

.changeset/real-poets-work.md

@@ -0,0 +1,5 @@
+---
+'@graphql-tools/utils': patch
+---
+
+Handle enum values correctly if they are arguments of directives defined in the extensions

packages/utils/src/astFromValue.ts

@@ -1,4 +1,3 @@
-import { inspect } from 'cross-inspect';
 import {
   GraphQLInputType,
   isEnumType,
@@ -95,29 +94,33 @@ export function astFromValue(value: unknown, type: GraphQLInputType): Maybe<Valu
   if (isLeafType(type)) {
     // Since value is an internally represented value, it must be serialized
     // to an externally represented value before converting into an AST.
-    const serialized = type.serialize(value);
-    if (serialized == null) {
-      return null;
-    }
-
     if (isEnumType(type)) {
-      return { kind: Kind.ENUM, value: serialized as string };
+      const values = type.getValues();
+      for (const enumValue of values) {
+        if (enumValue.value === value) {
+          value = enumValue.name;
+          break;
+        }
+        if (enumValue.name === value) {
+          value = enumValue.name;
+          break;
+        }
+      }
+      return { kind: Kind.ENUM, value: value as string };
+    } else {
+      value = type.serialize(value);
+    }
+    if (value == null) {
+      return null;
     }
 
     // ID types can use Int literals.
-    if (
-      type.name === 'ID' &&
-      typeof serialized === 'string' &&
-      integerStringRegExp.test(serialized)
-    ) {
-      return { kind: Kind.INT, value: serialized };
+    if (type.name === 'ID' && typeof value === 'string' && integerStringRegExp.test(value)) {
+      return { kind: Kind.INT, value };
     }
-
-    return astFromValueUntyped(serialized);
   }
-  /* c8 ignore next 3 */
-  // Not reachable, all possible types have been considered.
-  console.assert(false, 'Unexpected input type: ' + inspect(type));
+
+  return astFromValueUntyped(value);
 }
 
 /**

packages/utils/tests/print-schema-with-directives.spec.ts

@@ -404,6 +404,44 @@ describe('printSchemaWithDirectives', () => {
       expect(output).toContain('input OneOfInput @oneOf');
     }
   });
+  it('should print enum directive arg by name when internal value differs', () => {
+    const OAuthScopeEnum = new GraphQLEnumType({
+      name: 'OAuthScopeEnum',
+      values: {
+        TEAMS_WRITE: { value: 'teams:write' },
+      },
+    });
+
+    const scopeDirective = new GraphQLDirective({
+      name: 'scope',
+      args: {
+        name: { type: new GraphQLNonNull(OAuthScopeEnum) },
+      },
+      locations: ['FIELD_DEFINITION'] as any,
+    });
+
+    const schema = new GraphQLSchema({
+      directives: [...specifiedDirectives, scopeDirective],
+      query: new GraphQLObjectType({
+        name: 'Query',
+        fields: {
+          me: {
+            type: GraphQLString,
+            extensions: {
+              directives: {
+                scope: { name: 'TEAMS_WRITE' },
+              },
+            },
+          },
+        },
+      }),
+      types: [OAuthScopeEnum],
+    });
+
+    const output = printSchemaWithDirectives(schema);
+    expect(output).toContain('me: String @scope(name: TEAMS_WRITE)');
+  });
+
   it('prints a federation-style subgraph schema correctly', () => {
     const sdl = stripIgnoredCharacters(/* GraphQL */ `
       extend schema @link(url: "https://specs.apollo.dev/federation/v2.0", import: ["@key"])
@@ -417,4 +455,42 @@ describe('printSchemaWithDirectives', () => {
     const printedSchema = stripIgnoredCharacters(printSchemaWithDirectives(userSubgraph));
     expect(printedSchema).toBe(sdl);
   });
+
+  it('should print enum directive arg by name when internal value differs', () => {
+    const OAuthScopeEnum = new GraphQLEnumType({
+      name: 'OAuthScopeEnum',
+      values: {
+        TEAMS_WRITE: { value: 'teams:write' },
+      },
+    });
+
+    const scopeDirective = new GraphQLDirective({
+      name: 'scope',
+      args: {
+        name: { type: new GraphQLNonNull(OAuthScopeEnum) },
+      },
+      locations: ['FIELD_DEFINITION'] as any,
+    });
+
+    const schema = new GraphQLSchema({
+      directives: [...specifiedDirectives, scopeDirective],
+      query: new GraphQLObjectType({
+        name: 'Query',
+        fields: {
+          me: {
+            type: GraphQLString,
+            extensions: {
+              directives: {
+                scope: { name: 'TEAMS_WRITE' },
+              },
+            },
+          },
+        },
+      }),
+      types: [OAuthScopeEnum],
+    });
+
+    const output = printSchemaWithDirectives(schema);
+    expect(output).toContain('me: String @scope(name: TEAMS_WRITE)');
+  });
 });