fix(argo-cd): Update ingress class annotation for GKE compatibility (#3493)

* fix(ingress): update ingress class annotation for GKE compatibility

Signed-off-by: Tiago Gigli <tiago@privateid.com>

* chore(chart): bump version to 8.3.8 and update changelog annotations

Signed-off-by: Tiago Gigli <tiago@privateid.com>

* chore: Drop changelog entry from previous PR

Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>

* chore: Add newline

Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>

* chore: Bump chart version again after resolving merge conflicts

Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>

---------

Signed-off-by: Tiago Gigli <tiago@privateid.com>
Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>

Author: tgigli

charts/argo-cd/Chart.yaml

@@ -3,7 +3,7 @@ appVersion: v3.1.5
 kubeVersion: ">=1.25.0-0"
 description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
 name: argo-cd
-version: 8.3.8
+version: 8.3.9
 home: https://github.com/argoproj/argo-helm
 icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
 sources:
@@ -27,4 +27,4 @@ annotations:
     url: https://argoproj.github.io/argo-helm/pgp_keys.asc
   artifacthub.io/changes: |
     - kind: fixed
-      description: Correct instruction how to override argocd-params-cm.
+      description: Update ingress class annotation for GKE compatibility

charts/argo-cd/templates/argocd-server/gke/ingress.yaml

@@ -12,7 +12,9 @@ metadata:
       {{- toYaml . | nindent 4 }}
     {{- end }}
   annotations:
-    ingressClassName: "gce"
+    {{- with .Values.server.ingress.ingressClassName }}
+    kubernetes.io/ingress.class: {{ . }}
+    {{- end }}
     {{- if .Values.server.ingress.gke.managedCertificate.create }}
     networking.gke.io/managed-certificates: {{ include "argo-cd.server.fullname" . }}
     {{- end }}
@@ -23,9 +25,6 @@ metadata:
     {{ $key }}: {{ $value | quote }}
     {{- end }}
 spec:
-  {{- with .Values.server.ingress.ingressClassName }}
-  ingressClassName: {{ . }}
-  {{- end }}
   rules:
     - host: {{ .Values.server.ingress.hostname | default .Values.global.domain }}
       http: