-
Notifications
You must be signed in to change notification settings - Fork 0
Scaling factor logic in vehicle link count #238
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
The current scaling logic in the code for link_vehicle_counts here is designed to handle cars and PT modes.
This leads to issues where non-PT modes such as bike, taxi, and walk are not scaled properly.
scale_factor = self.config.scale_factor
if self.mode != "car":
scale_factor = 1.0
We observed that modes for bikes are not scaled. And non-public transport modes (including taxi, bike, and walk) should be appropriately scaled.
It may need a better name for the event handler e.g mode_link_counts if we would like to use this to get the links count for other modes.
When vehicle_link_counts produced the link counts output for taxi, it seems wrong since all the counts are equal to zero. Worth to check the logic for non-car mode.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working