Commit 46be943
Exclude WASM artifacts from GitHub releases (#23221)
## Summary
Fixes #23127.
The `release.yml` workflow downloads artifacts using `pattern:
artifacts-*` with `merge-multiple: true`. The three WASM build targets
(web, bundler, nodejs) were uploaded as `artifacts-wasm-{target}`,
matching that glob. Since all three
contain identically-named files, they silently overwrote each other
during the
merge, making the released WASM assets non-deterministic.
Renaming the artifacts from `artifacts-wasm-*` to `wasm-npm-*` excludes
them from the `artifacts-*` glob in `release.yml`. Notably, the npm
publish workflow is unaffected (it downloads each target by exact
artifact
name and was never subject to the merge conflict).
## Test Plan
N/A :p
Happy to investigate a test publish on my fork if anyone feels strongly
about this. However, npm does not appear to have a test registry like
PyPI -- and in any event testing seemed a bit involved -- so I didn't
rush to investigate this before review.
---------
Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>1 parent 6ded4be commit 46be943
2 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
| 58 | + | |
58 | 59 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
0 commit comments