Skip to content

Commit 701aecb

Browse files
authored
[red-knot] mypy_primer: Fail job on panic or internal errors (#17389)
## Summary Let the mypy_primer job fail if Red Knot panics or exits with code 2 (indicating an internal error). Corresponding mypy_primer commit: astral-sh/mypy_primer@90808f4 In addition, we may also want to make a successful mypy_primer run required for merging? ## Test Plan Made sure that mypy_primer exits with code 70 locally on panics, which should result in a pipeline failure, since we only allow code 0 and 1 in the pipeline here: https://github.com/astral-sh/ruff/blob/a4d7c6669bb356eb40e6e7069b11dffbfc27f483/.github/workflows/mypy_primer.yaml#L73
1 parent 850360a commit 701aecb

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/mypy_primer.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545

4646
- name: Install mypy_primer
4747
run: |
48-
uv tool install "git+https://github.com/astral-sh/mypy_primer.git@add-red-knot-support-v4"
48+
uv tool install "git+https://github.com/astral-sh/mypy_primer.git@add-red-knot-support-v5"
4949
5050
- name: Run mypy_primer
5151
shell: bash

0 commit comments

Comments
 (0)