fix(executable): stricter regex for uv/uvx/uv tool run

Author: Jkhall81

crates/ruff_linter/resources/test/fixtures/flake8_executable/EXE003_uv.py

@@ -1,5 +1,17 @@
 #!/usr/bin/env -S uv run
 print("hello world")
 
-#!/usr/bin/env uv --quiet run
 #!/usr/bin/env uv --offline run
+print("offline")
+
+#!/usr/bin/env uvx run
+print("uvx")
+
+#!/usr/bin/env uv tool run
+print("uv tool")
+
+#!/usr/bin/env uvx --quiet run
+print("uvx quiet")
+
+#!/usr/bin/env uv_not_really_run
+print("this should fail")

crates/ruff_linter/src/rules/flake8_executable/rules/shebang_missing_python.rs

@@ -1,11 +1,16 @@
-use ruff_text_size::TextRange;
+use std::sync::LazyLock;
 
+use regex::Regex;
 use ruff_macros::{ViolationMetadata, derive_message_formats};
+use ruff_text_size::TextRange;
 
 use crate::Violation;
 use crate::checkers::ast::LintContext;
 use crate::comments::shebang::ShebangDirective;
 
+static UV_RUN_REGEX: LazyLock<Regex> =
+    LazyLock::new(|| Regex::new(r"(?x) \b(?:uv|uvx|uv\s+tool)\b .* \s run \b").unwrap());
+
 /// ## What it does
 /// Checks for a shebang directive in `.py` files that does not contain `python`,
 /// `pytest`, or `uv run`.
@@ -48,12 +53,7 @@ pub(crate) fn shebang_missing_python(
     shebang: &ShebangDirective,
     context: &LintContext,
 ) {
-    if shebang.contains("python")
-        || shebang.contains("pytest")
-        || (shebang.contains("uv") && shebang.contains("run"))
-        || shebang.contains("uvx")
-        || shebang.contains("uv tool run")
-    {
+    if shebang.contains("python") || shebang.contains("pytest") || UV_RUN_REGEX.is_match(shebang) {
         return;
     }
 

crates/ruff_linter/src/rules/flake8_executable/snapshots/ruff_linter__rules__flake8_executable__tests__EXE003_uv.py.snap

@@ -6,15 +6,57 @@ EXE005 Shebang should be at the beginning of the file
   |
 2 | print("hello world")
 3 |
-4 | #!/usr/bin/env uv --quiet run
-  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-5 | #!/usr/bin/env uv --offline run
+4 | #!/usr/bin/env uv --offline run
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+5 | print("offline")
   |
 
 EXE005 Shebang should be at the beginning of the file
- --> EXE003_uv.py:5:1
+ --> EXE003_uv.py:7:1
   |
-4 | #!/usr/bin/env uv --quiet run
-5 | #!/usr/bin/env uv --offline run
-  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+5 | print("offline")
+6 |
+7 | #!/usr/bin/env uvx run
+  | ^^^^^^^^^^^^^^^^^^^^^^
+8 | print("uvx")
   |
+
+EXE005 Shebang should be at the beginning of the file
+  --> EXE003_uv.py:10:1
+   |
+ 8 | print("uvx")
+ 9 |
+10 | #!/usr/bin/env uv tool run
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^
+11 | print("uv tool")
+   |
+
+EXE005 Shebang should be at the beginning of the file
+  --> EXE003_uv.py:13:1
+   |
+11 | print("uv tool")
+12 |
+13 | #!/usr/bin/env uvx --quiet run
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+14 | print("uvx quiet")
+   |
+
+EXE003 Shebang should contain `python`, `pytest`, or `uv run`
+  --> EXE003_uv.py:16:1
+   |
+14 | print("uvx quiet")
+15 |
+16 | #!/usr/bin/env uv_not_really_run
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+17 | print("this should fail")
+   |
+
+EXE005 Shebang should be at the beginning of the file
+  --> EXE003_uv.py:16:1
+   |
+14 | print("uvx quiet")
+15 |
+16 | #!/usr/bin/env uv_not_really_run
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+17 | print("this should fail")
+   |

crates/ruff_linter/src/rules/flake8_executable/snapshots/ruff_linter__rules__flake8_executable__tests__EXE003_uvx.py.snap

@@ -1,4 +1,10 @@
 ---
 source: crates/ruff_linter/src/rules/flake8_executable/mod.rs
 ---
-
+EXE003 Shebang should contain `python`, `pytest`, or `uv run`
+ --> EXE003_uvx.py:1:1
+  |
+1 | #!/usr/bin/env -S uvx ruff check --isolated --select EXE003
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+2 | print("hello world")
+  |