Skip to content

Commit 958e117

Browse files
ntBreMichaReiser
authored andcommitted
[pyupgrade] Stabilize non-pep646-unpack (UP044) (#16632)
Summary -- Stabilizes UP044, renames the module to match the rule name, and removes the `PreviewMode` from the test settings. Test Plan -- 2 closed issues in November, just after the rule was added, otherwise no issues
1 parent fce5d89 commit 958e117

4 files changed

Lines changed: 3 additions & 4 deletions

File tree

crates/ruff_linter/src/codes.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
538538
(Pyupgrade, "041") => (RuleGroup::Stable, rules::pyupgrade::rules::TimeoutErrorAlias),
539539
(Pyupgrade, "042") => (RuleGroup::Preview, rules::pyupgrade::rules::ReplaceStrEnum),
540540
(Pyupgrade, "043") => (RuleGroup::Stable, rules::pyupgrade::rules::UnnecessaryDefaultTypeArgs),
541-
(Pyupgrade, "044") => (RuleGroup::Preview, rules::pyupgrade::rules::NonPEP646Unpack),
541+
(Pyupgrade, "044") => (RuleGroup::Stable, rules::pyupgrade::rules::NonPEP646Unpack),
542542
(Pyupgrade, "045") => (RuleGroup::Preview, rules::pyupgrade::rules::NonPEP604AnnotationOptional),
543543
(Pyupgrade, "046") => (RuleGroup::Preview, rules::pyupgrade::rules::NonPEP695GenericClass),
544544
(Pyupgrade, "047") => (RuleGroup::Preview, rules::pyupgrade::rules::NonPEP695GenericFunction),

crates/ruff_linter/src/rules/pyupgrade/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@ mod tests {
285285
let diagnostics = test_path(
286286
Path::new("pyupgrade/UP044.py"),
287287
&settings::LinterSettings {
288-
preview: PreviewMode::Enabled,
289288
unresolved_target_version: PythonVersion::PY311,
290289
..settings::LinterSettings::for_rule(Rule::NonPEP646Unpack)
291290
},

crates/ruff_linter/src/rules/pyupgrade/rules/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ pub(crate) use format_literals::*;
1111
pub(crate) use lru_cache_with_maxsize_none::*;
1212
pub(crate) use lru_cache_without_parameters::*;
1313
pub(crate) use native_literals::*;
14+
pub(crate) use non_pep646_unpack::*;
1415
pub(crate) use open_alias::*;
1516
pub(crate) use os_error_alias::*;
1617
pub(crate) use outdated_version_block::*;
@@ -36,7 +37,6 @@ pub(crate) use unpacked_list_comprehension::*;
3637
pub(crate) use use_pep585_annotation::*;
3738
pub(crate) use use_pep604_annotation::*;
3839
pub(crate) use use_pep604_isinstance::*;
39-
pub(crate) use use_pep646_unpack::*;
4040
pub(crate) use useless_metaclass_type::*;
4141
pub(crate) use useless_object_inheritance::*;
4242
pub(crate) use yield_in_for_loop::*;
@@ -54,6 +54,7 @@ mod format_literals;
5454
mod lru_cache_with_maxsize_none;
5555
mod lru_cache_without_parameters;
5656
mod native_literals;
57+
mod non_pep646_unpack;
5758
mod open_alias;
5859
mod os_error_alias;
5960
mod outdated_version_block;
@@ -79,7 +80,6 @@ mod unpacked_list_comprehension;
7980
mod use_pep585_annotation;
8081
mod use_pep604_annotation;
8182
mod use_pep604_isinstance;
82-
mod use_pep646_unpack;
8383
mod useless_metaclass_type;
8484
mod useless_object_inheritance;
8585
mod yield_in_for_loop;

crates/ruff_linter/src/rules/pyupgrade/rules/use_pep646_unpack.rs renamed to crates/ruff_linter/src/rules/pyupgrade/rules/non_pep646_unpack.rs

File renamed without changes.

0 commit comments

Comments
 (0)