[testing] Revert "[pylint] Implement swap-with-temporary-variable (PLR1712) (#22205)"

This is an alternative to #23588, checking the ecosystem results in comparison.

Author: ntBre

crates/ruff_linter/resources/test/fixtures/pylint/swap_with_temporary_variable.py

@@ -28,7 +28,6 @@ pub(crate) fn deferred_scopes(checker: &Checker) {
         Rule::RuntimeImportInTypeCheckingBlock,
         Rule::SingledispatchMethod,
         Rule::SingledispatchmethodFunction,
-        Rule::SwapWithTemporaryVariable,
         Rule::TooManyLocals,
         Rule::TypingOnlyFirstPartyImport,
         Rule::TypingOnlyStandardLibraryImport,
@@ -95,10 +94,6 @@ pub(crate) fn deferred_scopes(checker: &Checker) {
             pylint::rules::global_variable_not_assigned(checker, scope);
         }
 
-        if checker.is_rule_enabled(Rule::SwapWithTemporaryVariable) {
-            pylint::rules::swap_with_temporary_variable(checker, scope_id, scope);
-        }
-
         if checker.is_rule_enabled(Rule::RedefinedArgumentFromLocal) {
             pylint::rules::redefined_argument_from_local(checker, scope_id, scope);
         }

crates/ruff_linter/src/checkers/ast/analyze/deferred_scopes.rs

@@ -288,7 +288,6 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Pylint, "R1706") => rules::pylint::rules::AndOrTernary,
         (Pylint, "R1708") => rules::pylint::rules::StopIterationReturn,
         (Pylint, "R1711") => rules::pylint::rules::UselessReturn,
-        (Pylint, "R1712") => rules::pylint::rules::SwapWithTemporaryVariable,
         (Pylint, "R1714") => rules::pylint::rules::RepeatedEqualityComparison,
         (Pylint, "R1722") => rules::pylint::rules::SysExitAlias,
         (Pylint, "R1730") => rules::pylint::rules::IfStmtMinMax,

crates/ruff_linter/src/codes.rs

@@ -46,10 +46,6 @@ mod tests {
     #[test_case(Rule::CompareToEmptyString, Path::new("compare_to_empty_string.py"))]
     #[test_case(Rule::ComparisonOfConstant, Path::new("comparison_of_constant.py"))]
     #[test_case(Rule::ComparisonWithItself, Path::new("comparison_with_itself.py"))]
-    #[test_case(
-        Rule::SwapWithTemporaryVariable,
-        Path::new("swap_with_temporary_variable.py")
-    )]
     #[test_case(Rule::EqWithoutHash, Path::new("eq_without_hash.py"))]
     #[test_case(Rule::EmptyComment, Path::new("empty_comment.py"))]
     #[test_case(Rule::EmptyComment, Path::new("empty_comment_line_continuation.py"))]

crates/ruff_linter/src/rules/pylint/mod.rs

@@ -79,7 +79,6 @@ pub(crate) use stop_iteration_return::*;
 pub(crate) use subprocess_popen_preexec_fn::*;
 pub(crate) use subprocess_run_without_check::*;
 pub(crate) use super_without_brackets::*;
-pub(crate) use swap_with_temporary_variable::*;
 pub(crate) use sys_exit_alias::*;
 pub(crate) use too_many_arguments::*;
 pub(crate) use too_many_boolean_expressions::*;
@@ -191,7 +190,6 @@ mod stop_iteration_return;
 mod subprocess_popen_preexec_fn;
 mod subprocess_run_without_check;
 mod super_without_brackets;
-mod swap_with_temporary_variable;
 mod sys_exit_alias;
 mod too_many_arguments;
 mod too_many_boolean_expressions;