chore: ensure remaining specs restore resource items on failure (#4469)

* chore: ensure remaining specs restore resource items on failure

Follow-up to #4461. Same pattern: move trailing
`Avo::Resources::*.restore_items_from_backup` calls inside `it` blocks
into `ensure` clauses so the class-level `temporary_items` state is
cleaned up even when an expectation fails mid-test. Failures otherwise
leak the temporary block into subsequent tests where it is `instance_eval`d
in `detect_fields`, replacing the resource's normal field set.

Files audited: every spec that calls `with_temporary_items` or
`restore_items_from_backup`. Files already using `before`/`after`/`around`
hooks for cleanup are left untouched, as are the two intentionally-leaking
tests in `tags_spec.rb` (covered in #4461). Five files have inline
restore calls converted to `ensure`. One file
(`spec/features/avo/search_has_many_scope_spec.rb`) was missing the
restore entirely — added it in `ensure`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: fix flaky format_using tags spec by sharing setup via before/after

The two tests in the `format_using (same as deprecated fetch_labels)
with fetch_values_from` describe in `tags_spec.rb` had a hidden
inter-test dependency: `fetches the labels` set `with_temporary_items`,
`keep correct tags on validations error and edit` inherited the leaked
state. Under randomised order — or any environment where the leak does
not happen to land first — the second test failed because the default
Course resource has no `fetch_values_from` configured. This has been
observed flaking on main CI (e.g. system_specs job in run 25716241257).

Move the `with_temporary_items` setup into a `before` hook and the
`restore_items_from_backup` cleanup into an `after` hook. Both tests
are now self-contained and independent of execution order.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Paul Bob <69730720+Paul-Bob@users.noreply.github.com>

Author: 3 people

spec/features/avo/has_many_field_spec.rb

@@ -184,7 +184,7 @@
 
         expect(page).to have_css('[data-component-name="avo/filters_component"]')
         expect(page).to have_css('[data-search-target="autocomplete"]')
-
+      ensure
         Avo::Resources::Store.restore_items_from_backup
       end
     end
@@ -199,7 +199,7 @@
 
         expect(page).not_to have_css('[data-component-name="avo/filters_component"]')
         expect(page).not_to have_css('[data-search-target="autocomplete"]')
-
+      ensure
         Avo::Resources::Store.restore_items_from_backup
       end
     end

spec/features/avo/number_spec.rb

@@ -103,7 +103,7 @@
         visit "/admin/resources/projects/#{project.id}"
 
         expect(find_field_element(:users_required)).to have_text("10,000")
-
+      ensure
         Avo::Resources::Project.restore_items_from_backup
       end
     end
@@ -117,7 +117,7 @@
         visit "/admin/resources/projects"
 
         expect(find_field_element(:users_required)).to have_text("10,000")
-
+      ensure
         Avo::Resources::Project.restore_items_from_backup
       end
     end
@@ -135,7 +135,7 @@
         visit "/admin/resources/projects/#{project.id}"
 
         expect(find_field_element(:users_required)).to have_text("10,000")
-
+      ensure
         Avo::Resources::Project.restore_items_from_backup
       end
     end
@@ -149,7 +149,7 @@
         visit "/admin/resources/projects/#{project.id}/edit"
 
         expect(page).to have_field("project_users_required", with: "10,000")
-
+      ensure
         Avo::Resources::Project.restore_items_from_backup
       end
     end
@@ -163,7 +163,7 @@
         visit "/admin/resources/projects/#{project.id}/edit"
 
         expect(page).to have_field("project_users_required", with: "10,000")
-
+      ensure
         Avo::Resources::Project.restore_items_from_backup
       end
     end

spec/features/avo/search_has_many_scope_spec.rb

@@ -82,5 +82,7 @@
     3.times do |index|
       expect(json["course links"]["results"][index]["_id"]).to eq course_with_five_links.links[index].to_param
     end
+  ensure
+    Avo::Resources::Course.restore_items_from_backup
   end
 end

spec/system/avo/create_via_belongs_to_spec.rb

@@ -195,7 +195,7 @@
       within field_wrapper(:course) do
         expect(page).not_to have_text 'Create new course'
       end
-
+    ensure
       Avo::Resources::CourseLink.restore_items_from_backup
     end
   end

spec/system/avo/tabs_spec.rb

@@ -337,7 +337,7 @@
         expect(page).not_to have_text("tab_1")
         expect(page).not_to have_text("tab_2")
       end
-
+    ensure
       Avo::Resources::User.restore_items_from_backup
     end
   end

spec/system/avo/tags_spec.rb

@@ -181,7 +181,7 @@
     let(:field_value_slot) { tags_element(find_field_value_element("skills")) }
     let(:tags_input) { field_value_slot.find("span[contenteditable]") }
 
-    it "fetches the labels" do
+    before do
       Avo::Resources::Course.with_temporary_items do
         field :name
         field :skills,
@@ -196,7 +196,13 @@
             end
           }
       end
+    end
+
+    after do
+      Avo::Resources::Course.restore_items_from_backup
+    end
 
+    it "fetches the labels" do
       visit avo.resources_courses_path
 
       expect(page).to have_text "#{users[0].first_name} #{users[0].last_name}"
@@ -230,8 +236,6 @@
       save
 
       expect(Course.last.skills.map(&:to_i)).to eql(users.pluck(:id))
-    ensure
-      Avo::Resources::Course.restore_items_from_backup
     end
   end
 

spec/system/avo/trix_field_spec.rb

@@ -93,7 +93,7 @@
 
           expect(page).not_to have_link("More content", href: "javascript:void(0);")
           expect(page).not_to have_link("Less content", href: "javascript:void(0);")
-
+        ensure
           Avo::Resources::Post.restore_items_from_backup
         end
       end
@@ -142,7 +142,7 @@
 
         expect(page).to have_selector(".trix-content")
         expect(page).to have_text(body)
-
+      ensure
         Avo::Resources::Post.restore_items_from_backup
       end
     end
@@ -158,7 +158,7 @@
 
         expect(page).to have_selector(".trix-content")
         expect(page).to have_text(body)
-
+      ensure
         Avo::Resources::Post.restore_items_from_backup
       end
     end