Merge branch 'refactor/hotkey-improvements' of github.com:avo-hq/avo into refactor/hotkey-improvements

Author: adrianthedev

spec/system/avo/actions_spec.rb

@@ -208,9 +208,6 @@
       find("body").native.send_keys(:escape)
 
       expect(page).to have_selector '[data-controller~="modal"]'
-
-      click_on "Cancel"
-      expect(page).not_to have_selector '[data-controller~="modal"]'
     end
   end
 

spec/system/avo/hotkey_spec.rb

@@ -13,8 +13,8 @@ def dispatch_keydown(key, code: nil, shift_key: false, ctrl_key: false, meta_key
         cancelable: true
       }
 
-      document.dispatchEvent(new KeyboardEvent("keydown", eventOptions))
-      window.dispatchEvent(new KeyboardEvent("keydown", eventOptions))
+      const eventTarget = document.body || document.documentElement
+      eventTarget.dispatchEvent(new KeyboardEvent("keydown", eventOptions))
     JS
   end
 
@@ -37,23 +37,25 @@ def dispatch_active_element_keydown(key)
 
   def dispatch_document_keydown(key, code: nil, shift_key: false, ctrl_key: false, meta_key: false, alt_key: false)
     page.evaluate_script(<<~JS)
-      const event = new KeyboardEvent("keydown", {
-        key: #{key.to_json},
-        code: #{code.to_json},
-        shiftKey: #{shift_key},
-        ctrlKey: #{ctrl_key},
-        metaKey: #{meta_key},
-        altKey: #{alt_key},
-        bubbles: true,
-        cancelable: true
-      })
+      (() => {
+        const event = new KeyboardEvent("keydown", {
+          key: #{key.to_json},
+          code: #{code.to_json},
+          shiftKey: #{shift_key},
+          ctrlKey: #{ctrl_key},
+          metaKey: #{meta_key},
+          altKey: #{alt_key},
+          bubbles: true,
+          cancelable: true
+        })
 
-      const dispatchResult = document.dispatchEvent(event)
+        const dispatchResult = document.dispatchEvent(event)
 
-      {
-        defaultPrevented: event.defaultPrevented,
-        dispatchResult: dispatchResult
-      }
+        return {
+          defaultPrevented: event.defaultPrevented,
+          dispatchResult
+        }
+      })()
     JS
   end