c++ compat: standard says only specific integral types are supported by uniform_int_distribution, causing issues with older libc++

m6w6 · m6w6 · commit 1e7775270209 · 2025-08-18T17:32:42.000+02:00
diff --git a/test/lib/random.cpp b/test/lib/random.cpp
@@ -50,7 +50,7 @@ string random_socket_or_port_flag(const string &binary) {
 }
 
 char random_ascii(char min, char max) {
-  return static_cast<char>(random_num(min, max));
+  return static_cast<char>(random_num(int(min), int(max)));
 }
 
 string random_ascii_string(size_t len, char min, char max) {
@@ -77,7 +77,7 @@ pair<string, string> random_ascii_pair(size_t minlen, size_t maxlen) {
 #include <climits>
 
 char random_binary() {
-  return random_num(CHAR_MIN, CHAR_MAX);
+  return random_num(int(CHAR_MIN), int(CHAR_MAX));
 }
 
 string random_binary_string(size_t len) {

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ string random_socket_or_port_flag(const string &binary) {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`char random_ascii(char min, char max) {`
`53`		`- return static_cast<char>(random_num(min, max));`
	`53`	`+ return static_cast<char>(random_num(int(min), int(max)));`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`string random_ascii_string(size_t len, char min, char max) {`
`@@ -77,7 +77,7 @@ pair<string, string> random_ascii_pair(size_t minlen, size_t maxlen) {`
`77`	`77`	`#include <climits>`
`78`	`78`
`79`	`79`	`char random_binary() {`
`80`		`- return random_num(CHAR_MIN, CHAR_MAX);`
	`80`	`+ return random_num(int(CHAR_MIN), int(CHAR_MAX));`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`string random_binary_string(size_t len) {`