If libcrypto implementation of AES is used, do not compile internal#122
Merged
m6w6 merged 1 commit intoawesomized:v1.xfrom Sep 23, 2021
Merged
If libcrypto implementation of AES is used, do not compile internal#122m6w6 merged 1 commit intoawesomized:v1.xfrom
m6w6 merged 1 commit intoawesomized:v1.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## v1.x #122 +/- ##
=======================================
- Coverage 68% 61% -8%
=======================================
Files 194 194
Lines 17478 15978 -1500
=======================================
- Hits 11929 9704 -2225
- Misses 5549 6274 +725
Continue to review full report at Codecov.
|
m6w6
added a commit
that referenced
this pull request
Aug 10, 2022
* Fix handling of negative expiration values, which are somehow allowed by legacy. See also [gh #125](#125), and [gh #76](#76). * Fix [gh #122](#122): If libcrypto implementation of AES is used, do not compile internal. * Fix missing include of <array> in tests. * Fix warnings with non-SASL builds. * Fix pthread.h detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is somewhat cosmetic change. When libcrypto implementation of
AES is used, rijndael.cc file does not have to be compiled and linked
into the library. This allows us to not list rijndael AES implementation
as bundled feature of libmemcached in Fedora and RHEL package.