Skip to content

If libcrypto implementation of AES is used, do not compile internal#122

Merged
m6w6 merged 1 commit intoawesomized:v1.xfrom
TomasKorbar:v1.x
Sep 23, 2021
Merged

If libcrypto implementation of AES is used, do not compile internal#122
m6w6 merged 1 commit intoawesomized:v1.xfrom
TomasKorbar:v1.x

Conversation

@TomasKorbar
Copy link
Copy Markdown
Contributor

Hi,
this is somewhat cosmetic change. When libcrypto implementation of
AES is used, rijndael.cc file does not have to be compiled and linked
into the library. This allows us to not list rijndael AES implementation
as bundled feature of libmemcached in Fedora and RHEL package.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #122 (65a1489) into v1.x (6079c0e) will decrease coverage by 8%.
The diff coverage is n/a.

❗ Current head 65a1489 differs from pull request most recent head 0dc8017. Consider uploading reports for the commit 0dc8017 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##            v1.x    #122     +/-   ##
=======================================
- Coverage     68%     61%     -8%     
=======================================
  Files        194     194             
  Lines      17478   15978   -1500     
=======================================
- Hits       11929    9704   -2225     
- Misses      5549    6274    +725     
Impacted Files Coverage Δ
src/libmemcached/common.h 0% <0%> (-100%) ⬇️
src/libmemcached/csl/context.h 0% <0%> (-87%) ⬇️
src/libmemcached/memory.h 0% <0%> (-86%) ⬇️
test/lib/Server.hpp 0% <0%> (-77%) ⬇️
src/libmemcached/auto.cc 0% <0%> (-69%) ⬇️
src/libmemcached/options.cc 0% <0%> (-63%) ⬇️
src/libmemcached/behavior.cc 12% <0%> (-60%) ⬇️
test/lib/random.hpp 40% <0%> (-60%) ⬇️
src/libmemcached/namespace.cc 0% <0%> (-58%) ⬇️
src/libmemcached/sasl.cc 0% <0%> (-49%) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6079c0e...0dc8017. Read the comment docs.

@m6w6 m6w6 merged commit aa88329 into awesomized:v1.x Sep 23, 2021
m6w6 added a commit that referenced this pull request Aug 10, 2022
* Fix handling of negative expiration values, which are somehow allowed by legacy.
  See also [gh #125](#125),
  and [gh #76](#76).
* Fix [gh #122](#122):
  If libcrypto implementation of AES is used, do not compile internal.
* Fix missing include of <array> in tests.
* Fix warnings with non-SASL builds.
* Fix pthread.h detection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants