Stdin overrides .cfnlintrc when determining templates (#4138)

* Stdin overrides .cfnlintrc when determining templates

Author: kddejong

src/cfnlint/config.py

@@ -775,10 +775,12 @@ def templates(self):
 
         if cli_alt_args:
             filenames = cli_alt_args
-        elif file_args:
-            filenames = file_args
         elif cli_args:
             filenames = cli_args
+        elif not sys.stdin.isatty():
+            return []
+        elif file_args:
+            filenames = file_args
         else:
             # No filenames found, could be piped in or be using the api.
             return None

test/unit/module/config/test_config_mixin.py

@@ -167,9 +167,10 @@ def test_config_force_with_update_specs(self, yaml_mock):
         self.assertEqual(config.update_specs, True)
 
     @patch("cfnlint.config.ConfigFileArgs._read_config", create=True)
-    def test_config_expand_paths(self, yaml_mock):
+    @patch("sys.stdin.isatty", return_va=True)
+    def test_config_expand_paths(self, isatty_mock, yaml_mock):
         """Test precedence in"""
-
+        isatty_mock.return_value = True
         yaml_mock.side_effect = [
             {"templates": ["test/fixtures/templates/public/*.yaml"]},
             {},
@@ -198,10 +199,12 @@ def test_config_expand_paths(self, yaml_mock):
         )
 
     @patch("cfnlint.config.ConfigFileArgs._read_config", create=True)
-    def test_config_expand_paths_nomatch(self, yaml_mock):
+    @patch("sys.stdin.isatty", return_va=True)
+    def test_config_expand_paths_nomatch(self, isatty_mock, yaml_mock):
         """Test precedence in"""
 
         filename = "test/fixtures/templates/nonexistant/*.yaml"
+        isatty_mock.return_value = True
         yaml_mock.side_effect = [
             {"templates": [filename]},
             {},
@@ -212,10 +215,14 @@ def test_config_expand_paths_nomatch(self, yaml_mock):
             self.assertEqual(len(config.templates), 1)
 
     @patch("cfnlint.config.ConfigFileArgs._read_config", create=True)
-    def test_config_expand_paths_nomatch_ignore_bad_template(self, yaml_mock):
+    @patch("sys.stdin.isatty", return_va=True)
+    def test_config_expand_paths_nomatch_ignore_bad_template(
+        self, isatty_mock, yaml_mock
+    ):
         """Test precedence in"""
 
         filename = "test/fixtures/templates/nonexistant/*.yaml"
+        isatty_mock.return_value = True
         yaml_mock.side_effect = [
             {"templates": [filename], "ignore_bad_template": True},
             {},
@@ -226,9 +233,10 @@ def test_config_expand_paths_nomatch_ignore_bad_template(self, yaml_mock):
         self.assertEqual(config.templates, [])
 
     @patch("cfnlint.config.ConfigFileArgs._read_config", create=True)
-    def test_config_expand_ignore_templates(self, yaml_mock):
+    @patch("sys.stdin.isatty", return_va=True)
+    def test_config_expand_ignore_templates(self, isatty_mock, yaml_mock):
         """Test ignore templates"""
-
+        isatty_mock.return_value = True
         yaml_mock.side_effect = [
             {
                 "templates": ["test/fixtures/templates/bad/resources/iam/*.yaml"],
@@ -248,9 +256,13 @@ def test_config_expand_ignore_templates(self, yaml_mock):
         self.assertEqual(len(config.templates), 3)
 
     @patch("cfnlint.config.ConfigFileArgs._read_config", create=True)
-    def test_config_expand_and_ignore_templates_with_bad_path(self, yaml_mock):
+    @patch("sys.stdin.isatty", return_va=True)
+    def test_config_expand_and_ignore_templates_with_bad_path(
+        self, isatty_mock, yaml_mock
+    ):
         """Test ignore templates"""
 
+        isatty_mock.return_value = True
         yaml_mock.side_effect = [
             {
                 "templates": ["test/fixtures/templates/bad/resources/iam/*.yaml"],
@@ -270,9 +282,11 @@ def test_config_expand_and_ignore_templates_with_bad_path(self, yaml_mock):
         self.assertEqual(len(config.templates), 4)
 
     @patch("cfnlint.config.ConfigFileArgs._read_config", create=True)
-    def test_config_merge(self, yaml_mock):
+    @patch("sys.stdin.isatty", return_va=True)
+    def test_config_merge(self, isatty_mock, yaml_mock):
         """Test merging lists"""
 
+        isatty_mock.return_value = True
         yaml_mock.side_effect = [
             {
                 "include_checks": ["I"],

test/unit/module/formatters/test_formatters.py

@@ -7,6 +7,7 @@
 import sys
 from pathlib import Path
 from test.testlib.testcase import BaseTestCase
+from unittest.mock import patch
 
 import defusedxml.ElementTree as ET
 
@@ -214,8 +215,10 @@ def test_pretty_formatter(self):
                 ),
             )
 
-    def test_pretty_formatter_pipe(self):
+    @patch("sys.stdin.isatty", return_va=True)
+    def test_pretty_formatter_pipe(self, isatty_mock):
         """Test pretty formatter"""
+        isatty_mock.return_value = True
         formatter = PrettyFormatter()
         self.config.cli_args.templates = None
         results = formatter.print_matches(

test/unit/module/runner/test_cli.py

@@ -79,7 +79,7 @@ def test_print_help(self, mock_isatty, mock_print_help):
 
         self.assertEqual(e.exception.code, 1)
         mock_print_help.assert_called_once()
-        mock_isatty.assert_called_once()
+        self.assertEqual(mock_isatty.call_count, 2)
 
     def test_bad_regions(self):
         config = ConfigMixIn(