test: lambda error responses

Author: monroeclinton

samcli/local/lambda_service/local_lambda_http_service.py

@@ -259,6 +259,8 @@ def _invoke_request_handler(self, function_name):
             if validation_error := self._validate_function_for_invocation(function_name):
                 return validation_error
 
+            # LocalLambdaService is blocking, so threads used by ThreadPoolExecutor
+            # will be cleaned up when Python exits by the ThreadPoolExecutor implementation
             self.executor.submit(self._invoke_async_lambda, **arguments)
             return self.service_response("", headers, 202)
 

tests/unit/local/lambda_service/test_lambda_error_responses.py

@@ -97,6 +97,19 @@ def test_generic_method_not_allowed(self, service_response_mock):
             405,
         )
 
+    @patch("samcli.local.services.base_local_service.BaseLocalService.service_response")
+    def test_validation_exception(self, service_response_mock):
+        service_response_mock.return_value = "ValidationException"
+
+        response = LambdaErrorResponses.validation_exception("ValidationException")
+
+        self.assertEqual(response, "ValidationException")
+        service_response_mock.assert_called_once_with(
+            '{"Type": "User", "Message": "ValidationException"}',
+            {"x-amzn-errortype": "ValidationException", "Content-Type": "application/json"},
+            400,
+        )
+
     @patch("samcli.local.services.base_local_service.BaseLocalService.service_response")
     def test_durable_execution_not_found(self, service_response_mock):
         service_response_mock.return_value = "DurableExecutionNotFound"
@@ -109,3 +122,16 @@ def test_durable_execution_not_found(self, service_response_mock):
             {"x-amzn-errortype": "ResourceNotFound", "Content-Type": "application/json"},
             404,
         )
+
+    @patch("samcli.local.services.base_local_service.BaseLocalService.service_response")
+    def test_container_creation_failed(self, service_response_mock):
+        service_response_mock.return_value = "ContainerCreationFailed"
+
+        response = LambdaErrorResponses.container_creation_failed("Container creation failed: test message")
+
+        self.assertEqual(response, "ContainerCreationFailed")
+        service_response_mock.assert_called_once_with(
+            '{"Type": "LocalService", "Message": "Container creation failed: test message"}',
+            {"x-amzn-errortype": "ContainerCreationFailed", "Content-Type": "application/json"},
+            501,
+        )

tests/unit/local/lambda_service/test_local_lambda_http_service.py

@@ -505,14 +505,14 @@ def fake_invoke(*args, **kwargs):
         response = service._invoke_request_handler(function_name="HelloWorld")
 
         # Assert that first a 202 response is returned
-        assert response.status_code == 202
+        self.assertEqual(response.status_code, 202)
 
         # Then assert that invoke has not finished
-        assert not finished.is_set()
+        self.assertFalse(finished.is_set())
         handler_returned.set()
 
         # Finally assert that invoke has finished
-        assert finished.wait(timeout=5), "Task never finished"
+        self.assertTrue(finished.wait(timeout=5), "Task never finished")
 
     @patch("samcli.local.lambda_service.local_lambda_http_service.LocalLambdaHttpService.service_response")
     @patch("samcli.local.lambda_service.local_lambda_http_service.ThreadPoolExecutor")