-
Notifications
You must be signed in to change notification settings - Fork 772
Expand file tree
/
Copy pathsetup_integ_test.go
More file actions
724 lines (638 loc) · 19.1 KB
/
setup_integ_test.go
File metadata and controls
724 lines (638 loc) · 19.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
//go:build integration
package transfermanager
import (
"bytes"
"context"
"crypto/rand"
"crypto/tls"
"flag"
"fmt"
"io"
"net/http"
"os"
"path/filepath"
"runtime"
"strings"
"testing"
"time"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/aws/arn"
"github.com/aws/aws-sdk-go-v2/config"
"github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager/types"
"github.com/aws/aws-sdk-go-v2/service/s3"
s3types "github.com/aws/aws-sdk-go-v2/service/s3/types"
"github.com/aws/aws-sdk-go-v2/service/sts"
)
var setupMetadata = struct {
AccountID string
Region string
Buckets struct {
Source struct {
Name string
ARN string
}
}
}{}
// s3 client to use for integ testing
var s3Client *s3.Client
// s3TransferManagerClient to use for integ testing
var s3TransferManagerClient *Client
// sts client to use for integ testing
var stsClient *sts.Client
// http client setting to use for integ testing
var testHTTPClient *http.Client
var region = "us-west-2"
// large object buffer to test multipart upload
var largeObjectBuf []byte
// TestMain executes at start of package tests
func TestMain(m *testing.M) {
flag.Parse()
flag.CommandLine.Visit(func(f *flag.Flag) {
if !(f.Name == "run" || f.Name == "test.run") {
return
}
value := f.Value.String()
if value == `NONE` {
os.Exit(0)
}
})
var result int
defer func() {
if r := recover(); r != nil {
fmt.Fprintln(os.Stderr, "S3 TransferManager integration tests panic,", r)
result = 1
}
os.Exit(result)
}()
var verifyTLS bool
var s3Endpoint string
flag.StringVar(&s3Endpoint, "s3-endpoint", "", "integration endpoint for S3")
flag.StringVar(&setupMetadata.AccountID, "account", "", "integration account id")
flag.BoolVar(&verifyTLS, "verify-tls", true, "verify server TLS certificate")
flag.Parse()
testHTTPClient = &http.Client{
Transport: &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: verifyTLS},
},
}
cfg, err := config.LoadDefaultConfig(context.Background(),
config.WithRegion(region))
if err != nil {
fmt.Fprintf(os.Stderr, "Error occurred while loading config with region %v, %v", region, err)
result = 1
return
}
// assign the http client
cfg.HTTPClient = testHTTPClient
// create a s3 client
s3cfg := cfg.Copy()
if len(s3Endpoint) != 0 {
s3cfg.EndpointResolver = aws.EndpointResolverFunc(func(service, region string) (aws.Endpoint, error) {
return aws.Endpoint{
URL: s3Endpoint,
PartitionID: "aws",
SigningName: "s3",
SigningRegion: region,
SigningMethod: "s3v4",
}, nil
})
}
// build s3 client from config
s3Client = s3.NewFromConfig(s3cfg)
// build s3 transfermanager client from config
s3TransferManagerClient = New(s3Client)
// build sts client from config
stsClient = sts.NewFromConfig(cfg)
// context
ctx := context.Background()
setupMetadata.AccountID, err = getAccountID(ctx)
if err != nil {
fmt.Fprintf(os.Stderr, "failed to get integration aws account id: %v\n", err)
result = 1
return
}
bucketCleanup, err := setupBuckets(ctx)
defer bucketCleanup()
if err != nil {
fmt.Fprintf(os.Stderr, "failed to setup integration test buckets: %v\n", err)
result = 1
return
}
largeObjectBuf = make([]byte, 20*1024*1024)
_, err = rand.Read(largeObjectBuf)
if err != nil {
fmt.Fprintf(os.Stderr, "failed to generate large object for multipart upload: %v\n", err)
result = 1
return
}
result = m.Run()
}
// getAccountID retrieves account id
func getAccountID(ctx context.Context) (string, error) {
if len(setupMetadata.AccountID) != 0 {
return setupMetadata.AccountID, nil
}
identity, err := stsClient.GetCallerIdentity(ctx, nil)
if err != nil {
return "", fmt.Errorf("error fetching caller identity, %w", err)
}
return *identity.Account, nil
}
// setupBuckets creates buckets needed for integration test
func setupBuckets(ctx context.Context) (func(), error) {
var cleanups []func()
cleanup := func() {
for i := range cleanups {
cleanups[i]()
}
}
bucketCreates := []struct {
name *string
arn *string
}{
{name: &setupMetadata.Buckets.Source.Name, arn: &setupMetadata.Buckets.Source.ARN},
}
for _, bucket := range bucketCreates {
*bucket.name = GenerateBucketName()
if err := SetupBucket(ctx, s3Client, *bucket.name); err != nil {
return cleanup, err
}
// Compute ARN
bARN := arn.ARN{
Partition: "aws",
Service: "s3",
Region: region,
AccountID: setupMetadata.AccountID,
Resource: fmt.Sprintf("bucket_name:%s", *bucket.name),
}.String()
*bucket.arn = bARN
bucketName := *bucket.name
cleanups = append(cleanups, func() {
if err := CleanupBucket(ctx, s3Client, bucketName); err != nil {
fmt.Fprintln(os.Stderr, err)
}
})
}
return cleanup, nil
}
type putObjectTestData struct {
Body io.Reader
ExpectBody []byte
ExpectError string
}
type downloadObjectTestData struct {
Body io.Reader
ExpectBody []byte
ExpectError string
OptFns []func(*Options)
}
type getObjectTestData struct {
Body io.Reader
ExpectBody []byte
ExpectGetError string
ExpectReadError string
OptFns []func(*Options)
}
// UniqueID returns a unique UUID-like identifier for use in generating
// resources for integration tests.
//
// TODO: duped from service/internal/integrationtest, remove after beta.
func UniqueID() string {
uuid := make([]byte, 16)
io.ReadFull(rand.Reader, uuid)
return fmt.Sprintf("%x", uuid)
}
func testPutObject(t *testing.T, bucket string, testData putObjectTestData, opts ...func(options *Options)) {
key := UniqueID()
_, err := s3TransferManagerClient.UploadObject(context.Background(),
&UploadObjectInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
Body: testData.Body,
}, opts...)
if err != nil {
if len(testData.ExpectError) == 0 {
t.Fatalf("expect no error, got %v", err)
}
if e, a := testData.ExpectError, err.Error(); !strings.Contains(a, e) {
t.Fatalf("expect error to contain %v, got %v", e, a)
}
} else {
if e := testData.ExpectError; len(e) != 0 {
t.Fatalf("expect error: %v, got none", e)
}
}
if len(testData.ExpectError) != 0 {
return
}
resp, err := s3Client.GetObject(context.Background(),
&s3.GetObjectInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
})
if err != nil {
t.Fatalf("expect no error, got %v", err)
}
b, _ := io.ReadAll(resp.Body)
if e, a := testData.ExpectBody, b; !bytes.EqualFold(e, a) {
t.Errorf("expect %s, got %s", e, a)
}
}
func testGetObject(t *testing.T, bucket string, testData getObjectTestData) {
key := UniqueID()
_, err := s3Client.PutObject(context.Background(),
&s3.PutObjectInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
Body: testData.Body,
})
if err != nil {
t.Fatalf("expect no error, got %v", err)
}
out, err := s3TransferManagerClient.GetObject(context.Background(),
&GetObjectInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
}, testData.OptFns...)
if err != nil {
if len(testData.ExpectGetError) == 0 {
t.Fatalf("expect no error when getting object, got %v", err)
}
if e, a := testData.ExpectGetError, err.Error(); !strings.Contains(a, e) {
t.Fatalf("expect error to contain %v, got %v", e, a)
}
} else {
if e := testData.ExpectGetError; len(e) != 0 {
t.Fatalf("expect error when getting object: %v, got none", e)
}
}
if len(testData.ExpectGetError) != 0 {
return
}
b, err := io.ReadAll(out.Body)
if err != nil {
if len(testData.ExpectReadError) == 0 {
t.Fatalf("expect no error when reading responses, got %v", err)
}
if e, a := testData.ExpectReadError, err.Error(); !strings.Contains(a, e) {
t.Fatalf("expect error to contain %v, got %v", e, a)
}
} else {
if e := testData.ExpectReadError; len(e) != 0 {
t.Fatalf("expect error when reading responses: %v, got none", e)
}
}
if len(testData.ExpectReadError) != 0 {
return
}
if e, a := testData.ExpectBody, b; !bytes.EqualFold(e, a) {
t.Errorf("expect %s, got %s", e, a)
}
}
func testDownloadObject(t *testing.T, bucket string, testData downloadObjectTestData) {
key := UniqueID()
_, err := s3Client.PutObject(context.Background(),
&s3.PutObjectInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
Body: testData.Body,
})
if err != nil {
t.Fatalf("expect no error, got %v", err)
}
w := types.NewWriteAtBuffer(make([]byte, 0))
_, err = s3TransferManagerClient.DownloadObject(context.Background(),
&DownloadObjectInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
WriterAt: w,
}, testData.OptFns...)
if err != nil {
if len(testData.ExpectError) == 0 {
t.Fatalf("expect no error, got %v", err)
}
if e, a := testData.ExpectError, err.Error(); !strings.Contains(a, e) {
t.Fatalf("expect error to contain %v, got %v", e, a)
}
} else {
if e := testData.ExpectError; len(e) != 0 {
t.Fatalf("expect error: %v, got none", e)
}
}
if len(testData.ExpectError) != 0 {
return
}
if e, a := testData.ExpectBody, w.Bytes(); !bytes.EqualFold(e, a) {
t.Errorf("expect %s, got %s", e, a)
}
}
type uploadDirectoryTestData struct {
FilesSize map[string]int64
Source string
Recursive bool
KeyPrefix string
ExpectFilesUploaded int64
ExpectKeys []string
ExpectError string
}
func testUploadDirectory(t *testing.T, bucket string, testData uploadDirectoryTestData) {
_, filename, _, _ := runtime.Caller(0)
root := filepath.Join(filepath.Dir(filename), "testdata")
delimiter := "/"
expectObjects := map[string][]byte{}
source := filepath.Join(root, testData.Source)
if err := os.MkdirAll(source, os.ModePerm); err != nil {
t.Fatalf("error when creating test folder %v", err)
}
defer os.RemoveAll(source)
for f, size := range testData.FilesSize {
path := filepath.Join(source, strings.Replace(f, "/", string(os.PathSeparator), -1))
if err := os.MkdirAll(filepath.Dir(path), os.ModePerm); err != nil {
t.Fatalf("error when creating directory for file %s", path)
}
objectBuf := make([]byte, size)
_, err := rand.Read(objectBuf)
if err != nil {
t.Fatalf("error when mocking test data for file %s", path)
}
file, err := os.Create(path)
if err != nil {
t.Fatalf("error when opening test file %s: %v", path, err)
}
_, err = file.Write(objectBuf)
if err != nil {
t.Fatalf("error when writing test file %s: %v", path, err)
}
key := strings.Replace(f, "/", delimiter, -1)
if testData.KeyPrefix != "" {
key = testData.KeyPrefix + delimiter + key
}
expectObjects[key] = objectBuf
}
out, err := s3TransferManagerClient.UploadDirectory(context.Background(), &UploadDirectoryInput{
Bucket: aws.String(bucket),
Source: aws.String(source),
Recursive: aws.Bool(testData.Recursive),
KeyPrefix: aws.String(testData.KeyPrefix),
})
if err != nil {
if len(testData.ExpectError) == 0 {
t.Fatalf("expect no error, got %v", err)
}
if e, a := testData.ExpectError, err.Error(); !strings.Contains(a, e) {
t.Fatalf("expect error to contain %v, got %v", e, a)
}
} else {
if e := testData.ExpectError; len(e) != 0 {
t.Fatalf("expect error: %v, got none", e)
}
}
if len(testData.ExpectError) != 0 {
return
}
if e, a := testData.ExpectFilesUploaded, out.ObjectsUploaded; e != a {
t.Errorf("expect %d files uploaded, got %d", e, a)
}
for _, key := range testData.ExpectKeys {
resp, err := s3Client.GetObject(context.Background(),
&s3.GetObjectInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
})
if err != nil {
t.Fatalf("error when getting object %s", key)
}
b, _ := io.ReadAll(resp.Body)
expectData, ok := expectObjects[key]
if !ok {
t.Errorf("no data recorded for object %s", key)
}
if e, a := expectData, b; !bytes.EqualFold(e, a) {
t.Errorf("for object %s, expect %s, got %s", key, e, a)
}
}
}
type downloadDirectoryTestData struct {
ObjectsSize map[string]int64
KeyPrefix string
ExpectObjectsDownloaded int64
ExpectFiles []string
ExpectError string
}
func testDownloadDirectory(t *testing.T, bucket string, testData downloadDirectoryTestData) {
_, filename, _, _ := runtime.Caller(0)
dst := filepath.Join(filepath.Dir(filename), "testdata", "integ")
defer os.RemoveAll(dst)
delimiter := "/"
keyprefix := testData.KeyPrefix
if keyprefix != "" && !strings.HasSuffix(keyprefix, delimiter) {
keyprefix = keyprefix + delimiter
}
expectFiles := map[string][]byte{}
for key, size := range testData.ObjectsSize {
fileBuf := make([]byte, size)
_, err := rand.Read(fileBuf)
if err != nil {
t.Fatalf("error when mocking test data for object %s", key)
}
_, err = s3Client.PutObject(context.Background(),
&s3.PutObjectInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
Body: bytes.NewReader(fileBuf),
})
if err != nil {
t.Fatalf("error when putting object %s", key)
}
file := strings.ReplaceAll(strings.TrimPrefix(key, keyprefix), delimiter, string(os.PathSeparator))
expectFiles[file] = fileBuf
}
out, err := s3TransferManagerClient.DownloadDirectory(context.Background(), &DownloadDirectoryInput{
Bucket: aws.String(bucket),
Destination: aws.String(dst),
KeyPrefix: aws.String(testData.KeyPrefix),
})
if err != nil {
if len(testData.ExpectError) == 0 {
t.Fatalf("expect no error, got %v", err)
}
if e, a := testData.ExpectError, err.Error(); !strings.Contains(a, e) {
t.Fatalf("expect error to contain %v, got %v", e, a)
}
} else {
if e := testData.ExpectError; len(e) != 0 {
t.Fatalf("expect error: %v, got none", e)
}
}
if len(testData.ExpectError) != 0 {
return
}
if e, a := testData.ExpectObjectsDownloaded, out.ObjectsDownloaded; e != a {
t.Errorf("expect %d objects downloaded, got %d", e, a)
}
for _, file := range testData.ExpectFiles {
f := strings.ReplaceAll(file, delimiter, string(os.PathSeparator))
path := filepath.Join(dst, f)
b, err := os.ReadFile(path)
if err != nil {
t.Fatalf("error when reading downloaded file %s: %v", path, err)
}
expectData, ok := expectFiles[f]
if !ok {
t.Errorf("no data recorded for file %s", path)
continue
}
if e, a := expectData, b; !bytes.EqualFold(e, a) {
t.Errorf("for file %s, expect %s, got %s", f, e, a)
}
}
}
// TODO: duped from service/internal/integrationtest, remove after beta.
const expressAZID = "usw2-az3"
// TODO: duped from service/internal/integrationtest, remove after beta.
const expressSuffix = "--usw2-az3--x-s3"
// BucketPrefix is the root prefix of integration test buckets.
//
// TODO: duped from service/internal/integrationtest, remove after beta.
const BucketPrefix = "aws-sdk-go-v2-integration"
// GenerateBucketName returns a unique bucket name.
//
// TODO: duped from service/internal/integrationtest, remove after beta.
func GenerateBucketName() string {
return fmt.Sprintf("%s-%s",
BucketPrefix, UniqueID())
}
// GenerateBucketName returns a unique express-formatted bucket name.
//
// TODO: duped from service/internal/integrationtest, remove after beta.
func GenerateExpressBucketName() string {
return fmt.Sprintf(
"%s-%s%s",
BucketPrefix,
UniqueID()[0:8], // express suffix adds length, regain that here
expressSuffix,
)
}
// SetupBucket returns a test bucket created for the integration tests.
//
// TODO: duped from service/internal/integrationtest, remove after beta.
func SetupBucket(ctx context.Context, svc *s3.Client, bucketName string) (err error) {
fmt.Println("Setup: Creating test bucket,", bucketName)
_, err = svc.CreateBucket(ctx, &s3.CreateBucketInput{
Bucket: &bucketName,
CreateBucketConfiguration: &s3types.CreateBucketConfiguration{
LocationConstraint: "us-west-2",
},
})
if err != nil {
return fmt.Errorf("failed to create bucket %s, %v", bucketName, err)
}
// TODO: change this to use waiter to wait until BucketExists instead of loop
// svc.WaitUntilBucketExists(HeadBucketInput)
// HeadBucket to determine if bucket exists
var attempt = 0
params := &s3.HeadBucketInput{
Bucket: &bucketName,
}
pt:
_, err = svc.HeadBucket(ctx, params)
// increment an attempt
attempt++
// retry till 10 attempt
if err != nil {
if attempt < 10 {
goto pt
}
// fail if not succeed after 10 attempts
return fmt.Errorf("failed to determine if a bucket %s exists and you have permission to access it %v", bucketName, err)
}
return nil
}
// CleanupBucket deletes the contents of a S3 bucket, before deleting the bucket
// it self.
// TODO: list and delete methods should use paginators
//
// TODO: duped from service/internal/integrationtest, remove after beta.
func CleanupBucket(ctx context.Context, svc *s3.Client, bucketName string) (err error) {
var errs = make([]error, 0)
fmt.Println("TearDown: Deleting objects from test bucket,", bucketName)
listObjectsResp, err := svc.ListObjectsV2(ctx, &s3.ListObjectsV2Input{
Bucket: &bucketName,
})
if err != nil {
return fmt.Errorf("failed to list objects, %w", err)
}
for _, o := range listObjectsResp.Contents {
_, err := svc.DeleteObject(ctx, &s3.DeleteObjectInput{
Bucket: &bucketName,
Key: o.Key,
})
if err != nil {
errs = append(errs, err)
}
}
if len(errs) != 0 {
return fmt.Errorf("failed to delete objects, %s", errs)
}
fmt.Println("TearDown: Deleting partial uploads from test bucket,", bucketName)
multipartUploadResp, err := svc.ListMultipartUploads(ctx, &s3.ListMultipartUploadsInput{
Bucket: &bucketName,
})
if err != nil {
return fmt.Errorf("failed to list multipart objects, %w", err)
}
for _, u := range multipartUploadResp.Uploads {
_, err = svc.AbortMultipartUpload(ctx, &s3.AbortMultipartUploadInput{
Bucket: &bucketName,
Key: u.Key,
UploadId: u.UploadId,
})
if err != nil {
errs = append(errs, err)
}
}
if len(errs) != 0 {
return fmt.Errorf("failed to delete multipart upload objects, %s", errs)
}
fmt.Println("TearDown: Deleting test bucket,", bucketName)
_, err = svc.DeleteBucket(ctx, &s3.DeleteBucketInput{
Bucket: &bucketName,
})
if err != nil {
return fmt.Errorf("failed to delete bucket, %s", bucketName)
}
return nil
}
// SetupExpressBucket returns an express bucket for testing.
//
// TODO: duped from service/internal/integrationtest, remove after beta.
func SetupExpressBucket(ctx context.Context, svc *s3.Client, bucketName string) error {
if !strings.HasSuffix(bucketName, expressSuffix) {
return fmt.Errorf("bucket name %s is missing required suffix %s", bucketName, expressSuffix)
}
fmt.Println("Setup: Creating test express bucket,", bucketName)
_, err := svc.CreateBucket(ctx, &s3.CreateBucketInput{
Bucket: &bucketName,
CreateBucketConfiguration: &s3types.CreateBucketConfiguration{
Location: &s3types.LocationInfo{
Name: aws.String(expressAZID),
Type: s3types.LocationTypeAvailabilityZone,
},
Bucket: &s3types.BucketInfo{
DataRedundancy: s3types.DataRedundancySingleAvailabilityZone,
Type: s3types.BucketTypeDirectory,
},
},
})
if err != nil {
return fmt.Errorf("create express bucket %s: %v", bucketName, err)
}
w := s3.NewBucketExistsWaiter(svc)
err = w.Wait(ctx, &s3.HeadBucketInput{
Bucket: &bucketName,
}, 10*time.Second)
if err != nil {
return fmt.Errorf("wait for express bucket %s: %v", bucketName, err)
}
return nil
}