fix(rosetta): "Rosetta configured for live conversion to undefined" (#1120)

RomainMuller · skinny85 · commit 10e9d3863e36 · 2019-12-13T14:48:38.000-08:00
An incorrect update to optional chaining changed the criteria for the
target overlap test in Rosetta live conversions and triggered the error
in the regular case instead of only in cases where restricts have to be
enforced.

Reverted to the previous syntax with achieves the correct result.
diff --git a/packages/jsii-rosetta/lib/rosetta.ts b/packages/jsii-rosetta/lib/rosetta.ts
@@ -109,8 +109,8 @@ export class Rosetta {
     }
 
     if (!this.options.liveConversion) { return undefined; }
-    if (!this.options.targetLanguages?.includes(targetLang)) {
-      throw new Error(`Rosetta configured for live conversion to ${this.options.targetLanguages}, but requested ${targetLang}`);
+    if (this.options.targetLanguages && !this.options.targetLanguages.includes(targetLang)) {
+      throw new Error(`Rosetta configured for live conversion to ${this.options.targetLanguages.join(', ')}, but requested ${targetLang}`);
     }
 
     // See if we're going to live-convert it with full source information

Original file line number	Diff line number	Diff line change
`@@ -109,8 +109,8 @@ export class Rosetta {`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`if (!this.options.liveConversion) { return undefined; }`
`112`		`- if (!this.options.targetLanguages?.includes(targetLang)) {`
`113`		- throw new Error(`Rosetta configured for live conversion to ${this.options.targetLanguages}, but requested ${targetLang}`);
	`112`	`+ if (this.options.targetLanguages && !this.options.targetLanguages.includes(targetLang)) {`
	`113`	+ throw new Error(`Rosetta configured for live conversion to ${this.options.targetLanguages.join(', ')}, but requested ${targetLang}`);
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`// See if we're going to live-convert it with full source information`