chore: stop testing Node 17 (EOL for > 1 month) (#3691)

Author: RomainMuller

.github/workflows/main.yml

@@ -218,8 +218,7 @@ jobs:
         java: ['8']
         node:
           - '14' # EOL 2023-04-30
-          - '16' # EOL 2024-04-30
-          - '17' # EOL 2022-06-01
+          - '16' # EOL 2023-09-11
           - '18' # EOL 2025-04-30
         os: [ubuntu-latest]
         python: ['3.7']

.mergify/config.yml

@@ -10,7 +10,6 @@ queue_rules:
       # One test for each supported nodejs version
       - status-success~=^Test \(.* node 14 .*$
       - status-success~=^Test \(.* node 16 .*$
-      - status-success~=^Test \(.* node 17 .*$
       - status-success~=^Test \(.* node 18 .*$
       # One test for each supported dotnet version
       - status-success~=^Test \(.* dotnet 3\.1\.x .*$
@@ -60,7 +59,6 @@ pull_request_rules:
       # One test for each supported nodejs version
       - status-success~=^Test \(.* node 14 .*$
       - status-success~=^Test \(.* node 16 .*$
-      - status-success~=^Test \(.* node 17 .*$
       - status-success~=^Test \(.* node 18 .*$
       # One test for each supported dotnet version
       - status-success~=^Test \(.* dotnet 3\.1\.x .*$
@@ -110,7 +108,6 @@ pull_request_rules:
       # One test for each supported nodejs version
       - status-success~=^Test \(.* node 14 .*$
       - status-success~=^Test \(.* node 16 .*$
-      - status-success~=^Test \(.* node 17 .*$
       - status-success~=^Test \(.* node 18 .*$
       # One test for each supported dotnet version
       - status-success~=^Test \(.* dotnet 3\.1\.x .*$
@@ -160,7 +157,6 @@ pull_request_rules:
       # One test for each supported nodejs version
       - status-success~=^Test \(.* node 14 .*$
       - status-success~=^Test \(.* node 16 .*$
-      - status-success~=^Test \(.* node 17 .*$
       - status-success~=^Test \(.* node 18 .*$
       # One test for each supported dotnet version
       - status-success~=^Test \(.* dotnet 3\.1\.x .*$

CONTRIBUTING.md

@@ -39,7 +39,7 @@ The following tools need to be installed to develop on JSII locally. We recommen
 using the docker image from the above section, but if you wish to, you can install
 in your development environment.
 
-- [Node `12.7.0`] or later
+- [Node `14.6.0`] or later
 - [Yarn `1.19.1`] or later
 - An OpenJDK-8 distribution (e.g: [Oracle's OpenJDK8], [Amazon Corretto 8])
   + [`maven >= 3.0.5`](https://maven.apache.org)
@@ -51,7 +51,7 @@ in your development environment.
   + [`wheel`](https://pypi.org/project/wheel/)
   + *Recommended:* [`twine`](https://pypi.org/project/twine/)
 
-[Node `12.7.0`]: https://nodejs.org/download/release/v12.7.0/
+[Node `14.6.0`]: https://nodejs.org/download/release/v14.6.0/
 [Yarn `1.19.1`]: https://yarnpkg.com/en/docs/install
 [Oracle's OpenJDK8]: http://openjdk.java.net/install/
 [Amazon Corretto 8]: https://aws.amazon.com/corretto/

packages/@jsii/check-node/src/index.test.ts

@@ -11,7 +11,7 @@ test('tested node releases are correctly registered & supported', () => {
 
 // This test is there to ensure house-keeping happens when it should. If we are
 // testing a given node release, it must not have been EOL for over 60 days.
-test('tested node release have not ben EOL for more than 60 days', () => {
+test(`tested node release (${process.version}) has not ben EOL for more than 60 days`, () => {
   const { nodeRelease } = NodeRelease.forThisRuntime();
   expect(nodeRelease?.endOfLifeDate?.getTime()).toBeGreaterThan(
     Date.now() - 60 * 86_400_000,