fix(extmgr): address review follow-ups

Author: ayagmar

README.md

@@ -109,7 +109,7 @@ When Pi is running without UI, extmgr still supports command-driven workflows:
 - `/extensions update [source]`
 - `/extensions history [options]`
 - `/extensions auto-update <duration>`
-  - Use `1mo` for monthly schedules (history keeps `30m`/`24h` style durations for lookback windows)
+  - Use `1mo` for monthly schedules (`/extensions history --since <duration>` also accepts `1mo`; `30m`/`24h` are just lookback examples)
 
 Remote browsing/search menus require the full interactive TUI.
 
@@ -128,14 +128,14 @@ History options (works in non-interactive mode too):
 - `--action <extension_toggle|extension_delete|package_install|package_update|package_remove|cache_clear|auto_update_config>`
 - `--success` / `--failed`
 - `--package <query>`
-- `--since <duration>` (e.g. `30m`, `24h`, `7d`, `1mo`)
+- `--since <duration>` (e.g. `30m`, `24h`, `7d`, `1mo`; `1mo` is supported for monthly lookbacks)
 - `--global` (non-interactive mode only; reads all persisted sessions under `~/.pi/agent/sessions`)
 
 Examples:
 
 - `/extensions history --failed --limit 50`
 - `/extensions history --action package_update --since 7d`
-- `/extensions history --global --package extmgr --since 24h`
+- `/extensions history --global --package extmgr --since 1mo`
 
 ### Install sources
 
@@ -157,7 +157,7 @@ Examples:
   - After saving package extension config, restart pi to fully apply changes.
 - **Two install modes**:
   - **Managed** (npm): Auto-updates with `pi update`, stored in pi's package cache, supports Pi package manifest/convention loading
-  - **Local** (standalone): Copies to `~/.pi/agent/extensions/{package}/`, so it only accepts runnable standalone layouts (manifest-declared/root entrypoints), requires `tar` on `PATH`, and rejects packages whose runtime `dependencies` are not already bundled in the tarball
+  - **Local** (standalone): Copies to `~/.pi/agent/extensions/{package}/`, so it only accepts runnable standalone layouts (manifest-declared/root entrypoints), requires `tar` on `PATH`, and rejects packages whose runtime `dependencies` are not already bundled with the package contents
 - **Auto-update schedule is persistent**: `/extensions auto-update 1d` stays active across future Pi sessions and is restored when switching sessions.
 - **Auto-update coverage is npm-only today**: extmgr checks update availability for managed npm packages; git/local installs are not included in the background update badge yet.
 - **Settings/cache writes are hardened**: extmgr serializes writes and uses safe file replacement to reduce JSON corruption issues.

src/commands/history.ts

@@ -189,7 +189,7 @@ function showHistoryHelp(ctx: ExtensionCommandContext): void {
     "Options:",
     "  --limit <n>      Maximum entries to show (default: 20)",
     "  --action <type>  Filter by action",
-    "                   extension_toggle | extension_delete | package_install | package_update | package_remove | cache_clear | auto_update_config",
+    `                   ${HISTORY_ACTIONS.join(" | ")}`,
     "  --success        Show only successful entries",
     "  --failed         Show only failed entries",
     "  --package <q>    Filter by package/source/extension id",

src/packages/discovery.ts

@@ -16,6 +16,7 @@ import {
   getPackageSourceKind,
   normalizePackageIdentity,
   splitGitRepoAndRef,
+  stripGitSourcePrefix,
 } from "../utils/package-source.js";
 import { execNpm } from "../utils/npm-exec.js";
 
@@ -285,6 +286,12 @@ export async function isSourceInstalled(
   }
 }
 
+/**
+ * parseInstalledPackagesOutputAllScopes returns the raw parsed entries from
+ * parseInstalledPackagesOutputInternal without deduplication or scope merging.
+ * Prefer parseInstalledPackagesOutput for user-facing lists, since it applies
+ * deduplication and normalized scope selection.
+ */
 export function parseInstalledPackagesOutputAllScopes(text: string): InstalledPackage[] {
   return parseInstalledPackagesOutputInternal(text);
 }
@@ -325,7 +332,7 @@ function parsePackageNameAndVersion(fullSource: string): {
 
   const sourceKind = getPackageSourceKind(fullSource);
   if (sourceKind === "git") {
-    const gitSpec = fullSource.startsWith("git:") ? fullSource.slice(4) : fullSource;
+    const gitSpec = stripGitSourcePrefix(fullSource);
     const { repo } = splitGitRepoAndRef(gitSpec);
     return { name: extractGitPackageName(repo) };
   }

src/packages/install.ts

@@ -147,11 +147,20 @@ async function getStandaloneDependencyError(packageRoot: string): Promise<string
 }
 
 async function cleanupStandaloneTempArtifacts(tempDir: string, extractDir?: string): Promise<void> {
-  if (extractDir) {
-    await rm(extractDir, { recursive: true, force: true });
-  }
-
-  await rm(tempDir, { recursive: true, force: true });
+  const paths = [extractDir, tempDir].filter((path): path is string => Boolean(path));
+
+  await Promise.all(
+    paths.map(async (path) => {
+      try {
+        await rm(path, { recursive: true, force: true });
+      } catch (error) {
+        console.warn(
+          `[extmgr] Failed to remove temporary standalone install artifact at ${path}:`,
+          error
+        );
+      }
+    })
+  );
 }
 
 export async function installPackage(
@@ -273,7 +282,7 @@ export async function installFromUrl(
       await mkdir(extensionDir, { recursive: true });
       notify(ctx, `Downloading ${fileName}...`, "info");
 
-      const response = await fetchWithTimeout(url, TIMEOUTS.fetchPackageInfo);
+      const response = await fetchWithTimeout(url, TIMEOUTS.packageInstall);
       if (!response.ok) {
         throw new Error(`Download failed: ${response.status} ${response.statusText}`);
       }

src/ui/unified.ts

@@ -42,6 +42,7 @@ import { logExtensionDelete, logExtensionToggle } from "../utils/history.js";
 import { getKnownUpdates, promptAutoUpdateWizard } from "../utils/auto-update.js";
 import { updateExtmgrStatus } from "../utils/status.js";
 import { parseChoiceByLabel } from "../utils/command.js";
+import { notify } from "../utils/notify.js";
 import { getPackageSourceKind, normalizePackageIdentity } from "../utils/package-source.js";
 import { hasCustomUI, runCustomUI } from "../utils/mode.js";
 import { getSettingsListSelectedIndex } from "../utils/settings-list.js";
@@ -61,7 +62,8 @@ export async function showInteractive(
   pi: ExtensionAPI
 ): Promise<void> {
   if (!hasCustomUI(ctx)) {
-    ctx.ui.notify(
+    notify(
+      ctx,
       "The unified extensions manager requires the full interactive TUI. Showing read-only local and installed package lists instead.",
       "warning"
     );

src/utils/auto-update.ts

@@ -71,13 +71,6 @@ export function startAutoUpdateTimer(
     },
     { initialDelayMs }
   );
-
-  if (initialDelayMs > 0 && nextCheck !== undefined) {
-    saveAutoUpdateConfig(pi, {
-      ...config,
-      nextCheck,
-    });
-  }
 }
 
 /**
@@ -179,7 +172,7 @@ export function getAutoUpdateStatus(ctx: ExtensionCommandContext | ExtensionCont
 }
 
 /**
- * Return package names currently known to have updates available
+ * Return normalized package identities currently known to have updates available
  * (from the latest background check).
  */
 export function getKnownUpdates(ctx: ExtensionCommandContext | ExtensionContext): Set<string> {

src/utils/package-source.ts

@@ -56,6 +56,11 @@ export function normalizeLocalSourceIdentity(source: string): string {
   return looksWindowsPath ? normalized.toLowerCase() : normalized;
 }
 
+export function stripGitSourcePrefix(source: string): string {
+  const withoutGitPlus = source.startsWith("git+") ? source.slice(4) : source;
+  return withoutGitPlus.startsWith("git:") ? withoutGitPlus.slice(4) : withoutGitPlus;
+}
+
 export function normalizePackageIdentity(
   source: string,
   options?: { resolvedPath?: string }
@@ -69,7 +74,7 @@ export function normalizePackageIdentity(
   }
 
   if (kind === "git") {
-    const gitSpec = normalized.startsWith("git:") ? normalized.slice(4) : normalized;
+    const gitSpec = stripGitSourcePrefix(normalized);
     const { repo } = splitGitRepoAndRef(gitSpec);
     return `git:${repo.replace(/\\/g, "/").toLowerCase()}`;
   }

src/utils/settings-list.ts

@@ -8,5 +8,5 @@ export function getSettingsListSelectedIndex(settingsList: unknown): number | un
   }
 
   const selectable = settingsList as SelectableListLike;
-  return typeof selectable.selectedIndex === "number" ? selectable.selectedIndex : undefined;
+  return Number.isInteger(selectable.selectedIndex) ? selectable.selectedIndex : undefined;
 }

src/utils/settings.ts

@@ -11,6 +11,7 @@ import { readFile, writeFile, mkdir, rename, rm } from "node:fs/promises";
 import { homedir } from "node:os";
 import { join } from "node:path";
 import { fileExists } from "./fs.js";
+import { normalizePackageIdentity } from "./package-source.js";
 
 export interface AutoUpdateConfig {
   intervalMs: number;
@@ -57,7 +58,9 @@ function sanitizeUpdateIdentities(value: unknown): string[] | undefined {
   const updates = sanitizeStringArray(value);
   if (!updates) return undefined;
 
-  const sanitized = updates.filter(isUpdateIdentity);
+  const sanitized = updates
+    .filter(isUpdateIdentity)
+    .map((entry) => normalizePackageIdentity(entry));
   return sanitized.length > 0 ? sanitized : undefined;
 }
 

test/auto-update.test.ts

@@ -298,9 +298,8 @@ void test("enableAutoUpdate records the next scheduled check without faking a co
   try {
     enableAutoUpdate(pi, ctx, 60 * 60 * 1000, "1 hour");
 
-    const latestConfig = entries[entries.length - 1]?.data as
-      | { lastCheck?: number; nextCheck?: number; enabled?: boolean }
-      | undefined;
+    const latestConfig = entries.filter((entry) => entry.customType === "extmgr-auto-update").at(-1)
+      ?.data as { lastCheck?: number; nextCheck?: number; enabled?: boolean } | undefined;
 
     assert.equal(latestConfig?.enabled, true);
     assert.equal(latestConfig?.lastCheck, undefined);
@@ -332,3 +331,33 @@ void test("getKnownUpdates ignores legacy name-only update markers", () => {
 
   assert.deepEqual(Array.from(getKnownUpdates(ctx)), []);
 });
+
+void test("getKnownUpdates normalizes stored update identities", () => {
+  const ctx = {
+    hasUI: false,
+    cwd: "/tmp",
+    sessionManager: {
+      getEntries: () => [
+        {
+          type: "custom",
+          customType: "extmgr-auto-update",
+          data: {
+            enabled: true,
+            intervalMs: 60 * 60 * 1000,
+            displayText: "1 hour",
+            updatesAvailable: [
+              "npm:Demo-Pkg",
+              "git:HTTPS://GitHub.com/User/Repo.git@main",
+              "not-an-identity",
+            ],
+          },
+        },
+      ],
+    },
+  } as unknown as ReturnType<typeof createMockHarness>["ctx"];
+
+  assert.deepEqual(Array.from(getKnownUpdates(ctx)).sort(), [
+    "git:https://github.com/user/repo.git",
+    "npm:demo-pkg",
+  ]);
+});